Merged
Conversation
SCDerox
previously approved these changes
May 29, 2022
Member
SCDerox
left a comment
SCDerox
left a comment
There was a problem hiding this comment.
It works - but trying to fetch the message in each channel is kinda inefficient, I would suggest storing the channel-id in the database as well
Member
|
If you want, I can merge it as it is, or you could implement the suggested change - in either case, please let me know |
Contributor
Author
|
I'll try to implement your suggestion |
SCDerox
dismissed
their stale review
contributor wants to add additional features
Member
|
FYI: I will push some close-sourced changes we added to the welcomer module, should not interfere with your changes ^^ |
SCDerox
approved these changes
May 29, 2022
Member
SCDerox
left a comment
SCDerox
left a comment
There was a problem hiding this comment.
lgtm, thanks for your contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added option in the welcomer module to delete the welcome messages of users when they leave within 7 days after their join