cherry-studio-pre: Update to version 1.7.0-rc.1, add arm64 support, switch to portable release#2587
Conversation
WalkthroughThe Scoop manifest Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Your changes did not pass all checks. Please address the issues in the manifest and comment starting with cherry-studio-pre
|
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
bucket/cherry-studio-pre.json(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: AndisGrossteins
Repo: ScoopInstaller/Versions PR: 2575
File: bucket/perl-pdl.json:5-5
Timestamp: 2025-11-11T14:02:01.033Z
Learning: In bucket/perl-pdl.json, Strawberry Perl PDL stopped releasing 32-bit versions after 5.32.1.1, while 64-bit continues to receive updates. The manifest correctly uses the latest 64-bit version as the global version field since Scoop schema doesn't support architecture-specific version properties.
Learnt from: o-l-a-v
Repo: ScoopInstaller/Versions PR: 2564
File: bucket/olive-editor.json:24-24
Timestamp: 2025-11-07T10:15:21.033Z
Learning: In Scoop manifest JSON files, PowerShell commands in arrays like `pre_install` require backslashes to be escaped as `\\` in the JSON. After JSON parsing, `"$dir\\file.exe"` correctly becomes `$dir\file.exe` in PowerShell. This is proper JSON escaping, not an error.
🔇 Additional comments (4)
bucket/cherry-studio-pre.json (4)
18-19: Shortcut name change improves clarity and avoids conflicts.The shortcut has been renamed from "Cherry Studio.exe" / "Cherry Studio" to "Cherry-Studio.exe" / "Cherry Studio Preview", which aligns with the PR objective to avoid naming conflicts. The executable name matches the file renaming via the URL fragment
#/Cherry-Studio.exe, so the mapping is correct. This change is also consistent with the shift to portable executables that don't require AppData integration.
11-14: ARM64 architecture support properly added.The new arm64 section mirrors the 64bit structure and is properly nested within the architecture object. Scoop supports multi-architecture applications through the architecture object and includes logic to handle ARM64 compatibility by falling back to compatible architectures when ARM64-specific configurations are unavailable. The arm64 portable URL and hash follow the correct naming convention.
25-26: Incorrect review comment: The described checkver configuration does not exist in the manifest.The review comment references a jsonpath filter and specific regex pattern on lines 25-26, but the actual manifest's checkver shows:
"url": "https://api.github.com/repos/CherryHQ/cherry-studio/releases""regex": "download/v([\\d.]+)/"- No jsonpath field present
The current regex pattern is fundamentally incompatible with the GitHub API response format. The pattern
download/v([\\d.]+)/expects a URL with a "download/" prefix, but the API returns JSON objects withtag_namevalues like"v1.7.0-beta.6". Additionally, the regex[\\d.]+cannot capture prerelease suffixes (e.g., "-beta.6").Either the review comment describes proposed changes that were never applied, or the manifest has been reverted since the review was written.
Likely an incorrect or invalid review comment.
8-9: Verify hash values and URL accessibility for v1.7.0-beta.6 release assets.The manifest references SHA256 hashes (64 hex characters) for portable executables. Manual verification is needed:
- Visit the GitHub releases page for v1.7.0-beta.6
- Confirm the portable .exe files exist at the URLs specified (lines 8 and 12)
- Verify the SHA256 hashes match by downloading each asset and computing its checksum
- Additionally, verify that the
beta.ymlfile referenced in the autoupdate section is available in the upstream repository (noted as depending on CherryHQ/cherry-studio#11288)Also applies to: 12-13
|
/verify. Update to version 1.7.0-rc.1, remove autoupdate hash extraction. |
|
All changes look good. Wait for review from human collaborators. cherry-studio-pre
|
z-Fng
left a comment
There was a problem hiding this comment.
Thanks!
Note: Hash retrieval is dependent on the implementation of CherryHQ/cherry-studio#11288 .
Autoupdate Hash Extraction has been removed for now. If the beta*.yml and rc*.yml files start using the same filename in the future, contributions to add it back would be very welcome.
<manifest-name[@version]|chore>: <general summary of the pull request>$Env:AppData\CherryStudioclose #2586
Note: Hash retrieval is dependent on the implementation of CherryHQ/cherry-studio#11288 .
Summary by CodeRabbit
New Features
Updates
Removals