Skip to content

Conversation

@igitur
Copy link
Contributor

@igitur igitur commented Nov 13, 2025

The .zip file's structure has changed and zed.exe is now in a zed directory in the .zip file.

Relates to:

  • Use conventional PR title: <manifest-name[@version]|chore>: <general summary of the pull request>
  • I have read the Contributing Guide

Summary by CodeRabbit

  • Chores
    • Updated manifest to include a top-level extraction directory setting and an additional binary path entry.
    • Manifest now lists both the original executable reference and an alternate path under the extraction directory.
    • This configuration change alters how setup/extraction details are declared and may affect tools that read the manifest.

@coderabbitai
Copy link

coderabbitai bot commented Nov 13, 2025

Walkthrough

Added two top-level fields to the manifest bucket/zed-nightly.json: extract_dir set to "zed", and a new bin set to "bin\\zed.exe".

Changes

Cohort / File(s) Summary
Manifest Configuration
bucket/zed-nightly.json
Added top-level fields: extract_dir = "zed" and bin = "bin\\zed.exe"

Sequence Diagram(s)

Not applicable — no control-flow or runtime behavior changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A tiny manifest tweak, neat and spry,
extract_dir named "zed", reaching high,
bin points to bin\zed.exe in its nest,
A rabbit hops by, pleased with this quest. 🥕

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately reflects the main changes: updating zed-nightly manifest to fix extraction configuration and update the shim binary path.
Description check ✅ Passed The description provides context for the changes, references the related issue #2583, and confirms compliance with PR conventions and contributing guidelines.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ecfd816 and fc6c6e2.

📒 Files selected for processing (1)
  • bucket/zed-nightly.json (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • bucket/zed-nightly.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: PowerShell

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

zed-nightly

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

Check the full log for details.

@z-Fng z-Fng changed the title zed-nightly@2025-11-13: fix extract_dir zed-nightly@2025-11-13: Fix extraction, switch shim to the CLI binary Nov 13, 2025
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 566ba47 and ecfd816.

📒 Files selected for processing (1)
  • bucket/zed-nightly.json (1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-11-11T14:02:01.033Z
Learnt from: AndisGrossteins
Repo: ScoopInstaller/Versions PR: 2575
File: bucket/perl-pdl.json:5-5
Timestamp: 2025-11-11T14:02:01.033Z
Learning: In bucket/perl-pdl.json, Strawberry Perl PDL stopped releasing 32-bit versions after 5.32.1.1, while 64-bit continues to receive updates. The manifest correctly uses the latest 64-bit version as the global version field since Scoop schema doesn't support architecture-specific version properties.

Applied to files:

  • bucket/zed-nightly.json
🪛 Biome (2.1.2)
bucket/zed-nightly.json

[error] 13-13: The key bin was already declared.

This where a duplicated key was declared again.

If a key is defined multiple times, only the last definition takes effect. Previous definitions are ignored.

(lint/suspicious/noDuplicateObjectKeys)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: WindowsPowerShell
🔇 Additional comments (1)
bucket/zed-nightly.json (1)

12-14: Field ordering is correct per contributing guidelines.

The placement of extract_dir immediately after architecture and before bin aligns with the Scoop manifest field ordering documented in the contributing guide.

Copy link
Member

@z-Fng z-Fng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@z-Fng z-Fng merged commit 84da8f3 into ScoopInstaller:master Nov 13, 2025
3 checks passed
@z-Fng z-Fng linked an issue Nov 13, 2025 that may be closed by this pull request
3 tasks
@igitur igitur deleted the fix-zed branch November 14, 2025 07:56
@coderabbitai coderabbitai bot mentioned this pull request Jan 23, 2026
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: zed-nightly zip file structure has changed

2 participants