-
-
Notifications
You must be signed in to change notification settings - Fork 245
zed-nightly@2025-11-13: Fix extraction, switch shim to the CLI binary #2585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughAdded two top-level fields to the manifest Changes
Sequence Diagram(s)Not applicable — no control-flow or runtime behavior changes. Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
All changes look good. Wait for review from human collaborators. zed-nightly
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
bucket/zed-nightly.json(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-11-11T14:02:01.033Z
Learnt from: AndisGrossteins
Repo: ScoopInstaller/Versions PR: 2575
File: bucket/perl-pdl.json:5-5
Timestamp: 2025-11-11T14:02:01.033Z
Learning: In bucket/perl-pdl.json, Strawberry Perl PDL stopped releasing 32-bit versions after 5.32.1.1, while 64-bit continues to receive updates. The manifest correctly uses the latest 64-bit version as the global version field since Scoop schema doesn't support architecture-specific version properties.
Applied to files:
bucket/zed-nightly.json
🪛 Biome (2.1.2)
bucket/zed-nightly.json
[error] 13-13: The key bin was already declared.
This where a duplicated key was declared again.
If a key is defined multiple times, only the last definition takes effect. Previous definitions are ignored.
(lint/suspicious/noDuplicateObjectKeys)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: WindowsPowerShell
🔇 Additional comments (1)
bucket/zed-nightly.json (1)
12-14: Field ordering is correct per contributing guidelines.The placement of
extract_dirimmediately afterarchitectureand beforebinaligns with the Scoop manifest field ordering documented in the contributing guide.
z-Fng
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
The .zip file's structure has changed and
zed.exeis now in azeddirectory in the .zip file.Relates to:
<manifest-name[@version]|chore>: <general summary of the pull request>Summary by CodeRabbit