Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extract_dir from odin, odin-dev, and odin-nightly #2120

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jmtrue
Copy link

@jmtrue jmtrue commented Jan 24, 2025

Latest release no longer nests its contents inside the dist directory. Can remove the extract_dir until the next time they change the release structure.

Closes #2107

Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

odin-dev

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

odin-nightly

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

odin

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

@glektarssza
Copy link

Would be great to get this merged. It's been two weeks now and I can confirm these changes do work.

image

@Gaweringo
Copy link

As I noted on the other PR #2127 that tries to fix the same problem, they indeed have changed the release structure again:
For Odin 2025-02 there is now a new subdirectory again called odin-windows-amd64-dev-2025-02 which was reported on the Main bucket: ScoopInstaller/Main#6524 (comment)
Nightly still seems to use dist, at least the 2025-02-18 I tried.

So now extract_dir could be managed like https://github.com/ScoopInstaller/Main/blob/e472a2d55dd08afad4dcde9968622f4e9d8f4ad8/bucket/xh.json for example.

@deevus
Copy link
Member

deevus commented Mar 11, 2025

Instead of this back and forth dance, could a pre-install script be introduced that finds the folder that odin.exe is in for instance and then move that folder to the root?

@deevus deevus self-assigned this Mar 11, 2025
@glektarssza
Copy link

glektarssza commented Mar 11, 2025

Instead of this back and forth dance, could a pre-install script be introduced that finds the folder that odin.exe is in for instance and then move that folder to the root?

Possibly? I'm not entirely familiar with how scoop works internally but, knowing how Odin is structured, wherever the Odin binary is located everything should be located alongside that binary. So a pre-install script should be able to reorganize the unpacked zip file once it knows where that binary is to ensure it's all at the root level of the folder structure.

This is DEFINITELY the right approach to this issue. Good call out, @deevus!

@deevus
Copy link
Member

deevus commented Mar 11, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Odin
4 participants