fix (decompress): Expand-7zipArchive only delete temp dir / $extractDir if it is empty

[o-l-a-v]

Description

decompress.ps1 deletes $extractDir even if it's not empty, which can cause applications to not work after installation.

More context and how I got to this solution in following comment:

• [Bug] Missing folders after installing packages making applications behave incorrectly #6011 (comment)

Motivation and Context

Closes #6011, ScoopInstaller/Extras#13324

How Has This Been

Tested locally with scoop install extras/tor-browser.

Checklist:

• I have read the Contributing Guide.
• I have ensured that I am targeting the develop branch.
• I have updated the documentation accordingly.
• I have updated the tests accordingly.
• I have added an entry in the CHANGELOG.

[o-l-a-v]

If tests should be updated (tell me): Should be sufficient to add a .7z to https://github.com/ScoopInstaller/Scoop/blob/develop/test/fixtures/decompress/TestCases.zip with:

root
├─ $PLUGINSDIR
└─ keep
   └─ keep
      └─  file.txt

Then check that "$DestinationPath\keep" exists?

[niheaven]

Could you please sign your commit? And the logic should be tweaked by only check if $ExtractDir is empty.

[o-l-a-v]

Could you please sign your commit?

I've never done that before, I'll see if I can figure how. 👍

And the logic should be tweaked by only check if $ExtractDir is empty.

Isn't that what I do? If no child items inside it => delete. It's also possible to use Test-Path -Path '<directory>\*', but I like using Get-ChildItem for readability.

I also kept $ExtractDir -replace '[\\/].*. I don't really see why it's neccessary, but I tried doing as little changes as possible.

---

I now see that the other Expand-*Archive functions suffers from the same bug. Or maybe they don't?

[niheaven]

For commit signing, you could ref https://docs.github.com/authentication/managing-commit-signature-verification

[niheaven]

Hmm, you should try to pass the tests now :)

[o-l-a-v]

I think I've fixed the test errors now @niheaven: Can't do Get-ChildItem if -Path does not exist.