-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(release): Bump to version 0.4.0 #5424
Conversation
* fix(chore): Handle spaces in git command arguments * changelog * Use splatting
…sitories (#5361) Fix download from private GitHub repos
…xplicit arguments type (#5326) Co-authored-by: Hsiao-nan Cheung <niheaven@gmail.com>
…ormance (#5410) See: ScoopInstaller/Install#42 --------- Co-authored-by: Hsiao-nan Cheung <niheaven@gmail.com>
Oh yes, so waiting for them. I'll prepare for #5065 these two days. |
Opps! I forgot to change the title of #5346 before it got merged. 😅 |
* fix(shim): Use bash executable directly * Update CHANGELOG.md
There are some issues related to ScoopInstaller/Install#48, due to my two modifications: ScoopInstaller/Install#44 and #5395 An easily reproducible case is:
The code I modified caused a little problem with the environment variable session. If you pin a Windows Terminal on the taskbar and use it to open Powershell, the problem will be covered up. What I said may not be intuitive, anyway, my ScoopInstaller/Install#44 and #5395 modifications have some problems that need to be fixed. A more detailed description can be found in comment-1479699208 |
So the new method add path to current session only? Could you have a hotfix for it? |
No, the situation is very complicated. The modification of the registry is successful, and of course the modification of the Path is also successful, but the strange thing is that the session will not be modified in some cases at some places. Return to normal by doing some operations: Restart or manually save the editor of Path once (open Path and save it, no need to modify). Of course this is not acceptable. However I don't know how to deal with it, and I have a busy weekday, maybe I can spend the weekend exploring what is wrong. I apologize for the new bugs(shouldn't exist) I caused. |
Changing the registry value is not enough. |
Hey all, I have been using/customising scoop to my needs, I want to contribute a few tweaks upstream. Just wondering, 1: what is the anticipated release date of 0.4.0 is it too late to submit new changes? 2: How can I install 0.4.0 for testing? |
@( | ||
"@rem $resolved_path", | ||
"@`"$(Join-Path (Join-Path $gitdir.FullName 'bin') 'bash.exe')`" `"$resolved_path`" $arg %*" | ||
"@bash `"$resolved_path`" $arg %*" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…5577) Co-authored-by: Hsiao-nan Cheung <niheaven@gmail.com>
…r of `Expand-DarkArchive()` (#5871)
Changelog
Features
-Quiet
switch forInvoke-ExternalCommand
(feat(core): Add-Quiet
switch forInvoke-ExternalCommand
#5346)Bug Fixes
--verbose
(fix(scoop-info) --verbose file size collection #5352)scoop-virustotal
when--all
has been passed without app (fix(scoop-virustotal): continue exec when no app but -a provided #5593)is_in_dir
under Unix (fix(core): Fixis_in_dir
under Unix #5391)$scoopdir
(fix(core): Use relative path as fallback of$scoopdir
#5544)scoop
externally from inside the code (fix: do not callscoop
externally from inside the code #5695)Invoke-ExternalCommand()
(fix(core): Fix arguments parsing method ofInvoke-ExternalCommand()
#5839)wix.exe
in WiX Toolset v4+ as primary extractor ofExpand-DarkArchive()
(fix(decompress): Usewix.exe
in WiX Toolset v4+ as primary extractor ofExpand-DarkArchive()
#5871)%%
in env (fix(env): Avoid automatic expansion of%%
in env #5395, fix(env): Apply env immediately bySendMessageTimeout
#5452, fix(env): Publish environment change when deleting variable #5631)getopt()
and ensure array by explicit arguments type (fix(getopt): Stop split arguments ingetopt()
and ensure array by explicit arguments type #5326)Get-ShimPath
(fix(shim): Check literal path inGet-ShimPath
#5680)list
subcommand (fix(shim): Avoid unexpected output oflist
subcommand #5681)Performance Improvements
Expand-Archive
performance (perf(decompress): disable progress bar to improve Expand-Archive performance #5410)Code Refactoring
msi
section and config migration #5715, fix(install): Fix bugs in #5715 #5824)system.ps1
(refactor(core): Rewrite and separate path-related functions tosystem.ps1
#5836, fix(system): Remove EnvVar only if existed #5858, fix(scoop-shim): Import system.ps1 #5864)Builds
Continuous Integration
Tests
Documentation
Close Issues
scoop_*
properties in$scoopConfig
are invariably removed and re-added #5434HTTP(S)_PROXY
env vars modification byInvoke-Git
leak to current session #5435scoop
called externally from inside the code #5694scoop reset $apps
abort when one is running #5686Credits
Thanks to the following contributors (ordered by PR merging time):
@r15ch13 @niheaven @HUMORCE @rashil2000 @rasa @Ercolino @jeppefrandsen @chawyehsu @WHYBBE @Valinor @starthal @lewis-yeung @Lutra-Fs @walpox @spider2048 @gerardog @dooptydoo90x @hagaigold @davidlwatsonjr @svraka @amorphobia