feat(core): resolve GitHub workflow build artifact urls #5342
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I've added a new resolver to the
handle_special_urls
core function that allows downloading GitHub workflow build artifacts for a known artifact IDMotivation and Context
This allows updating nightly manifests where apps are built and uploaded from GitHub CI as workflow artifacts, so they don't have a fixed globally accessible URLs, but instead require using GitHub APIs to get to the temporary URL
Closes #5340
How Has This Been Tested?
Installed a nightly
libjxl
app with a manifest"url": "https://api.github.com/repos/libjxl/libjxl/actions/artifacts/508977204/zip/jxl-x64-windows-static.zip"
Run
C:\Dev\repo\Scoop\test\bin\test.ps1
, got 2 failures, but I don't see how these relate to the changes I've made, so I've ignored themChecklist:
develop
branch.