Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): resolve GitHub workflow build artifact urls #5342

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

eugenesvk
Copy link

Description

I've added a new resolver to the handle_special_urls core function that allows downloading GitHub workflow build artifacts for a known artifact ID

Motivation and Context

This allows updating nightly manifests where apps are built and uploaded from GitHub CI as workflow artifacts, so they don't have a fixed globally accessible URLs, but instead require using GitHub APIs to get to the temporary URL

Closes #5340

How Has This Been Tested?

  1. Installed a nightly libjxl app with a manifest "url": "https://api.github.com/repos/libjxl/libjxl/actions/artifacts/508977204/zip/jxl-x64-windows-static.zip"

  2. Run C:\Dev\repo\Scoop\test\bin\test.ps1, got 2 failures, but I don't see how these relate to the changes I've made, so I've ignored them

Describing is_in_dir
  [-] should work correctly 23ms (20ms|3ms)
   Expected $true, but got $false.
   at is_in_dir 'test' "$PSScriptRoot" | Should -BeTrue, C:\Dev\repo\Scoop\test\Scoop-Install.Tests.ps1:41
   at <ScriptBlock>, C:\Dev\repo\Scoop\test\Scoop-Install.Tests.ps1:41
Describing Manipulate Alias
  [+] Creates a new alias if alias doesn't exist 116ms (112ms|4ms)
  [-] Does not change existing alias if alias exists 213ms (209ms|4ms)
   CommandNotFoundException: The term 'test' is not recognized as a name of a cmdlet, function, script file, or executable program.
   Check the spelling of the name, or if a path was included, verify that the path is correct and try again.
   at <ScriptBlock>, C:\..\AppData\Local\Temp\52da3955-e8e3-444b-9a30-84e5d71ff87a\shims\scoop-rm.ps1:2
   at <ScriptBlock>, C:\Dev\repo\Scoop\test\Scoop-Alias.Tests.ps1:32

Checklist:

  • I have read the Contributing Guide.
  • I have ensured that I am targeting the develop branch.
  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.
  • I have added an entry in the CHANGELOG.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants