-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
builds(checkver): Implement SourceForge checkver functionality #5113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@se35710 Any problem? |
se35710
approved these changes
Sep 26, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Tested with some of the manifests in the original PR. Thank you!
5 tasks
pynappo
pushed a commit
to pynappo/Scoop
that referenced
this pull request
Sep 29, 2022
…Installer#5113) Co-authored-by: Mathias Hermansson <mathias.hermansson@se.ibm.com>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SourceForge checkver based on @se35710's previous work.
The following description is copied from #4560 and updated
In it's most simple form:
This will find the project name from homepage, or if that fails, from the manifest name.
A more comples example:
or simplified version (newly added, just likes github)
Here we provide the project name, and a path into the files section (to limit number of downloads).
project
is optional and only needed ifhomepage
or manifest name is not equal to the SourceForge project name.The default regex is
(?!\.)([\d.]+)(?<=\d)
and the actually used one is"CDATA\[/$path/.*?$sourceforgeRegex.*?\]".Replace('//', '/')
. Ifregex
orre
incheckver
is set, it is used as$sourceforgeRegex
.Motivation and Context
We have a lot of different approaches to SourceForge updates, this will help with maintaining those.
How Has This Been Tested?
I've copied some test manifests from #2455 and add more in ScoopInstaller/Tests#5
Checklist:
develop
branch.