-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(scoop-virustotal): Migrate to VirusTotal API v3 #4983
feat(scoop-virustotal): Migrate to VirusTotal API v3 #4983
Conversation
…and use standard psstreams
The code is already working. Any suggestions? |
Thanks for your work! Since you've nearly rewrote the whole file, reviewing may take more time, sorry~ Some suggestions, could you turn back to |
…and use standard psstreams
Is there some method that VT could be used without API Key? And could you add a hint that could guide users to sign in VT and get the API Key? |
The old api used by scoop is blocked: {
"error": {
"message": "Please re-send request with a valid reCAPTCHA response in the \"x-recaptcha-response\" header",
"code": "RecaptchaRequiredError"
}
}
Users only have to register an account. No other actions needed. |
The above commit is mainly to fix these issues.
I think I won't do another commit after this one. Unless there are bugs or suggestions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix help message and add API Key hint
Please add a changelog entry.
Co-authored-by: Hsiao-nan Cheung <niheaven@gmail.com>
Co-authored-by: Hsiao-nan Cheung <niheaven@gmail.com>
…and use standard psstreams
Description
Motivation and Context
Closes #4965
How Has This Been Tested?
Scans hundreds of apps.
Checklist:
develop
branch.