Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(release): Bump to version 0.2.1 #4982

Merged
merged 24 commits into from
Jun 10, 2022
Merged

chore(release): Bump to version 0.2.1 #4982

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
a2600b1
fix(buckets): Don't check remote URL of non-git buckets (#4923)
niheaven May 15, 2022
c6fc2de
fix(buckets): Don't write message OK before bucket is cloned (#4925)
chawyehsu May 15, 2022
b130e60
fix(depends): Avoid digits in archive file extension (#4915)
issaclin32 May 16, 2022
5d58703
docs(readme): Update license badge [skip ci] (#4929)
chawyehsu May 17, 2022
f49f976
fix(config): Load config file before initialization (#4932)
sprgchma May 17, 2022
bb5392b
fix(shim): Remove character replacement in .cmd -> .ps1 shims (#4914)
May 17, 2022
47d7f76
fix(scoop-info): Fix error message when manifest is not found (#4935)
quotidian-ennui May 17, 2022
ac2fb38
fix(scoop): Pass CLI arguments as string objects (#4931)
May 17, 2022
8140a20
fix(scoop-search): Require files in 'bucket' dir for remote known buc…
amorphobia May 24, 2022
ad04dc9
fix(core): Allow to use '_' and '.' in bucket name (#4952)
topstone May 25, 2022
d056d54
fix(core): Use Invoke-Command instead of Invoke-Expression (#4941)
niheaven May 26, 2022
896ea6c
chore: Update Nonportable bucket URL (#4955)
issaclin32 May 26, 2022
0f6d012
fix(shim): Add 'Get-CommandPath()' to find git (#4913)
rashil2000 May 27, 2022
2e52888
chore(core): Deprecate tls1 and tls1.1 (#4950)
neheb May 28, 2022
d6c6ddc
fix(update): Prevent uninstall when update (#4949)
rayinfinite Jun 1, 2022
dd0f514
feat(core): Add pre_uninstall and post_uninstall hooks (#4957)
chawyehsu Jun 1, 2022
78c1bc4
fix(scoop-uninstall): run pre_uninstall before testing running proces…
beer-psi Jun 3, 2022
ccd067b
refactor(manifest): Rename 'Find-Manifest()' to 'Get-Manifest()' (#4966)
niheaven Jun 7, 2022
3a1186e
docs(changelog): Update CHANGELOG (#4969)
niheaven Jun 7, 2022
bfb5c8d
fix(scoop-download): Use correct Args when calling `Get-Manifest` (#4…
HUMORCE Jun 10, 2022
3878357
docs(changelog): Fix CHANGELOG (#4977)
chawyehsu Jun 10, 2022
64364b4
fix(buckets): Make sure `list_buckets` return array (#4979)
danx12 Jun 10, 2022
9e70dca
fix(get-manfest): Add back '$appPath' (#4981)
niheaven Jun 10, 2022
ecb8f02
Merge branch 'master' into develop
niheaven Jun 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(scoop-uninstall): run pre_uninstall before testing running proces… 
…ses (#4962)
  • Loading branch information
@beer-psi
beer-psi authored Jun 3, 2022
commit 78c1bc45b4765e401a92e23d45de919cc2295112
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

### Features

- **core:** Add pre_uninstall and post_uninstall hooks ([#4957](https://github.com/ScoopInstaller/Scoop/issues/4957))
- **core:** Add pre_uninstall and post_uninstall hooks ([#4957](https://github.com/ScoopInstaller/Scoop/issues/4957), [#4962](https://github.com/ScoopInstaller/Scoop/issues/4962))

### Bug Fixes

Expand Down
12 changes: 6 additions & 6 deletions libexec/scoop-uninstall.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,12 @@ if (!$apps) { exit 0 }
$dir = versiondir $app $version $global
$persist_dir = persistdir $app $global

$manifest = installed_manifest $app $version $global
$install = install_info $app $version $global
$architecture = $install.architecture

Invoke-HookScript -HookType 'pre_uninstall' -Manifest $manifest -Arch $architecture

#region Workaround for #2952
if (test_running_process $app $global) {
continue
Expand All @@ -67,12 +73,6 @@ if (!$apps) { exit 0 }
continue
}

$manifest = installed_manifest $app $version $global
$install = install_info $app $version $global
$architecture = $install.architecture

Invoke-HookScript -HookType 'pre_uninstall' -Manifest $manifest -Arch $architecture

run_uninstaller $manifest $architecture $dir
rm_shims $app $manifest $global $architecture
rm_startmenu_shortcuts $manifest $global $architecture
Expand Down