Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(scoop-download): Use correct Args when calling Get-Manifest #4970

Merged
merged 2 commits into from
Jun 10, 2022
Merged

fix(scoop-download): Use correct Args when calling Get-Manifest #4970

merged 2 commits into from
Jun 10, 2022

Conversation

HUMORCE
Copy link
Member

@HUMORCE HUMORCE commented Jun 7, 2022 •
edited
Loading

Description

❯ scoop download mpv
INFO  Starting download for /mpv...
Loading mpv-0.34.0-x86_64.7z from cache
Checking hash of mpv-0.34.0-x86_64.7z ... ok.
'/mpv' (0.34.0) was downloaded successfully!

The appname appended with /(slash), when execute scoop download <app>

Motivation and Context

Closes #XXXX

Relates to #XXXX

How Has This Been Tested?

screenshot_20220607121554

Checklist:

  • I have read the Contributing Guide.
  • I have ensured that I am targeting the develop branch.
  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.
  • I have added an entry in the CHANGELOG.

@HUMORCE HUMORCE changed the title fix(scoop-download): Use correct variable when invoke Get-Manifest fix(scoop-download): Use correct Args when calling Get-Manifest Jun 7, 2022
@chawyehsu chawyehsu merged commit bfb5c8d into ScoopInstaller:develop Jun 10, 2022
This was referenced Jun 10, 2022
Merged
Merged
This was referenced Jun 10, 2022
Merged
Merged
@HUMORCE HUMORCE deleted the fix-scoop-download branch December 18, 2022 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chawyehsu chawyehsu chawyehsu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HUMORCE @chawyehsu