Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(scoop): Pass CLI arguments as string objects #4931

Merged
merged 4 commits into from
May 17, 2022
Merged

fix(scoop): Pass CLI arguments as string objects #4931

merged 4 commits into from
May 17, 2022

Conversation

lewis-yeung
Copy link
Contributor

@lewis-yeung lewis-yeung commented May 17, 2022 •
edited
Loading

Description

See #4927.

Motivation and Context

Fix #4927.

How Has This Been Tested?

With this fix, the following calls in PowerShell work correctly and won't throw exceptions:

  • scoop install <app> -s and scoop update <app> -s.
  • Any single-quoted short flags, e.g., scoop '-v'.

Checklist:

  • I have read the Contributing Guide.
  • I have ensured that I am targeting the develop branch.
  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.
  • I have added an entry in the CHANGELOG.

@rashil2000 rashil2000 requested a review from niheaven May 17, 2022 04:24
@niheaven
Copy link
Member

Just push a commit as review, and please check and test it.

lewis-yeung
lewis-yeung commented May 17, 2022
View reviewed changes
bin/scoop.ps1 Outdated Show resolved Hide resolved
@niheaven niheaven merged commit ac2fb38 into ScoopInstaller:develop May 17, 2022
@lewis-yeung lewis-yeung deleted the pass-args-as-strs branch May 17, 2022 16:06
@niheaven niheaven mentioned this pull request Jun 1, 2022
Merged
@niheaven niheaven mentioned this pull request Jun 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niheaven niheaven niheaven approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lewis-yeung @niheaven