Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(shim-kiennq): Update shimexe file name #4850

Merged
merged 2 commits into from
Apr 1, 2022

Conversation

kiennq
Copy link
Contributor

@kiennq kiennq commented Mar 31, 2022

With the new build pipeline in kiennq/scoop-better-shimexe@db29490, the artifact name will be shimexe.zip only

@rashil2000
Copy link
Member

Please use the develop branch instead of master

@kiennq kiennq changed the base branch from master to develop March 31, 2022 06:39
@kiennq
Copy link
Contributor Author

kiennq commented Mar 31, 2022

Please use the develop branch instead of master

Done

@niheaven
Copy link
Member

niheaven commented Mar 31, 2022

Update the CHANGELOG?

And, what does this Makefile do?

@kiennq
Copy link
Contributor Author

kiennq commented Apr 1, 2022

@niheaven I don't think this update is needed a CHANGELOG.
And for the purpose of this Makefile, I assume that @rasa is using it to automatically update to the latest release version of the shimexe

@rasa
Copy link
Member

rasa commented Apr 1, 2022

I assume that @rasa is using it to automatically update to the latest release version of the shimexe

It's run manually, though it could be called by a GitHub Action.

@niheaven
Copy link
Member

niheaven commented Apr 1, 2022

@niheaven I don't think this update is needed a CHANGELOG. And for the purpose of this Makefile, I assume that @rasa is using it to automatically update to the latest release version of the shimexe

Yes, I agree, so I'm asking why there's a Makefile 😄

I'll merge it and let's think about the future way of update the shim.

@niheaven niheaven merged commit 22c7d58 into ScoopInstaller:develop Apr 1, 2022
@kiennq kiennq deleted the fix/shim-name branch August 26, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants