fix(install): Use 'Get-Command' to test scoop install status #4785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chawyehsu
approved these changes
Mar 8, 2022
|
After this temporary hotfix, we should move https://github.com/ScoopInstaller/Install/blob/master/install.ps1 to Core repo while get.scoop.sh still points here. (Maybe the move should be made in the next release after adopting recent shim changes) |
rashil2000
approved these changes
Mar 8, 2022
|
Should sync develop with master after merging this |
|
Synced |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
installednow useGet-CurrentVersionfromversions.ps1which is not downloaded during installation. UseGet-Commandinstead (fromScoopInstall/Install)Motivation and Context
Closes #4783
How Has This Been Tested?
Tested in Windows SandBox
Checklist: