Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: Use correct casing for $PSScriptRoot #4775

Merged
merged 5 commits into from
Mar 4, 2022
Merged

style: Use correct casing for $PSScriptRoot #4775

merged 5 commits into from
Mar 4, 2022

Conversation

HUMORCE
Copy link
Member

@HUMORCE HUMORCE commented Mar 4, 2022 •
edited
Loading

  • Use correct casing for $PSScriptRoot
  • Fix imports in lib/autoupdate.ps1
  • Use back slash instead of forward slash

Checklist:

  • I have read the Contributing Guide.
  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.

niheaven
niheaven requested changes Mar 4, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@HUMORCE @niheaven
Update CHANGELOG.md
65ef85f 
Co-authored-by: Hsiao-nan Cheung <niheaven@gmail.com>
niheaven
niheaven approved these changes Mar 4, 2022
View reviewed changes
Copy link
Member

@niheaven niheaven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@niheaven niheaven merged commit 63b858c into ScoopInstaller:develop Mar 4, 2022
@HUMORCE HUMORCE deleted the fstyle branch March 4, 2022 16:47
@niheaven niheaven mentioned this pull request Mar 7, 2022
Merged
se35710 pushed a commit to se35710/scoop that referenced this pull request Mar 8, 2022
@HUMORCE @se35710
style: Use correct casing for $PSScriptRoot (ScoopInstaller#4775)
92c5b1a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niheaven niheaven niheaven approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HUMORCE @niheaven