fix(scoop-search): Remove redundant 'bucket/' in search result

[zStruCat]

Closes #4772

• I have read the Contributing Guide.

[rashil2000]

Actually, the bucket/ is not redundant. Sometimes multiple buckets have same package, so we specify scoop install <bucket>/<app> to install a particular app.

It would be better to replace the bucket/ word by the actual name of the bucket, like games/.

[zStruCat]

Actually, the bucket/ is not redundant. Sometimes multiple buckets have same package, so we specify scoop install <bucket>/<app> to install a particular app.

It would be better to replace the bucket/ word by the actual name of the bucket, like games/.

The display of searched manifests is divided into several section, each belonging to a particular bucket with its name displayed at the begining of the section, so perhaps there's no need for it to appear again in the manifest.

[rashil2000]

Then we should leave it as it is, because the instruction scoop install <bucket>/<app> is still important

[zStruCat]

Also, it's consistent with the display format of local bucket

Off the topic, i do think scoop install bucket/app is important. To be more precise, i feel that the form of bucket/app@version as a consistent input query is vital. Unfortunately, different command of scoop has acted inconsistently. For instance, search and list doesn't support bucket/app yet......

[rashil2000]

I think a common middle ground would be to make this result:

Results from other known buckets...
(add them using 'scoop bucket add <name>')

'nonportable' bucket:
    bucket/qttabbar-np

into

Results from other known buckets...
(add them using 'scoop bucket add <name>')

'nonportable' bucket (install using 'scoop install nonportable/<app>'):
    qttabbar-np

This will make it consistent with local bucket results.

[zStruCat]

I think a common middle ground would be to make this result:

Results from other known buckets...
(add them using 'scoop bucket add <name>')

'nonportable' bucket:
    bucket/qttabbar-np

into

Results from other known buckets...
(add them using 'scoop bucket add <name>')

'nonportable' bucket (install using 'scoop install nonportable/<app>'):
    qttabbar-np

This will make it consistent with local bucket results.

This is exactly what my commit do.

[rashil2000]

Notice the additional text beside the bucket header, that is not present in your commit

[zStruCat]

Notice the additional text beside the bucket header, that is not present in your commit

But scoop install cannot install app from a known but not added bucket. It results in the following:

WARN  Bucket 'games' not installed. Add it with 'scoop bucket add games' or 'scoop bucket add games <repo>'.  
Couldn't find manifest for '0ad' from 'games' bucket.

[rashil2000]

But scoop install cannot install app from a known but not added bucket. It results in the following:

Instruction for adding other known buckets is already given at the beginning of results, right

[zStruCat]

changed accordingly

[niheaven]

You should make bucket/ optional since it is not required in bucket repo.

[rashil2000]

You should make bucket/ optional since it is not required in bucket repo.

Do you mean the hint should only be shown for not added buckets?

[niheaven]

Do you mean the hint should only be shown for not added buckets?

No, the regex. Not all bucket repo has manifest files in 'bucket' subfolder, they may be put in root folder and that's scoop's original bucket structure.

[zStruCat]

Do you mean the hint should only be shown for not added buckets?

No, the regex. Not all bucket repo has manifest files in 'bucket' subfolder, they may be put in root folder and that's scoop's original bucket structure.

First, currently the remote search only search the remote 'known' bucket, i.e. main, extras, nirsoft, etc, all of which put manifests under bucket directory.
Secondly, if scaning all files, we won't be able to distinguish between a manifest and a normal json file without downloading and checking them against the schema. I doubt if the time-cost here is acceptable.

[zStruCat]

Any other issues?

[niheaven]

I've tweaked some code and now LGTM.