-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(scoop-bucket): Fix date formatting issues with git bucket(s) #4759
Conversation
One more thing. I don't think we need quotes for
variable. Meaning we can just say
while calling git. Can you check once? |
ae45590
to
b42e740
Compare
you are right, the git command still works fine after removing them, but many code still uses quotes like this. so, i will not change them in this PR. |
I actually wanted to remind you in your original buckets PR, but I forgot 😅
The only places where double quotes are needed are those where we use |
- scoop-bucket - scoop-status
okay, i did not notice that. also removed them from L18 of |
Description
Motivation and Context
Relates to #4756
How Has This Been Tested?
Checklist: