Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scoop-bucket): Fix date formatting issues with git bucket(s) #4759

Merged
merged 3 commits into from
Feb 25, 2022

Conversation

HUMORCE
Copy link
Member

@HUMORCE HUMORCE commented Feb 24, 2022

Description

Motivation and Context

Relates to #4756

How Has This Been Tested?

Checklist:

  • I have read the Contributing Guide.
  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.

@HUMORCE HUMORCE changed the base branch from master to develop February 24, 2022 17:00
rashil2000
rashil2000 previously approved these changes Feb 24, 2022
@rashil2000 rashil2000 changed the title fix(scoop-bucket): Fix date formatting issues with git bucket(s fix(scoop-bucket): Fix date formatting issues with git bucket(s) Feb 24, 2022
@rashil2000
Copy link
Member

One more thing. I don't think we need quotes for

"`"$source`"" 

variable. Meaning we can just say

$source

while calling git. Can you check once?

@HUMORCE
Copy link
Member Author

HUMORCE commented Feb 24, 2022

you are right, the git command still works fine after removing them, but many code still uses quotes like this.

so, i will not change them in this PR.

@rashil2000
Copy link
Member

rashil2000 commented Feb 24, 2022

I actually wanted to remind you in your original buckets PR, but I forgot 😅

but many code still uses quotes like this.

The only places where double quotes are needed are those where we use git_cmd function, because that function is run by cmd.exe. For generic git calls, parameters are handled by PowerShell so quoting is not needed.

- scoop-bucket
- scoop-status
@HUMORCE
Copy link
Member Author

HUMORCE commented Feb 24, 2022

okay, i did not notice that.

also removed them from L18 of scoop-status.ps1.

rashil2000
rashil2000 previously approved these changes Feb 24, 2022
@niheaven niheaven merged commit 0cb6152 into ScoopInstaller:develop Feb 25, 2022
@HUMORCE HUMORCE deleted the fix-scoop-bucket branch March 4, 2022 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants