Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(scoop-info): Use pipe to separate bins #4744

Merged
merged 1 commit into from
Feb 17, 2022
Merged

fix(scoop-info): Use pipe to separate bins #4744

merged 1 commit into from
Feb 17, 2022

Conversation

rashil2000
Copy link
Member

Hotfix for #4741

Before

image

After

image

@rashil2000 rashil2000 merged commit d1f828c into develop Feb 17, 2022
@rashil2000 rashil2000 deleted the info-bin-fix branch February 17, 2022 13:51
@niheaven
Copy link
Member

Maybe , is better? | makes me dizzy 🤣

@rashil2000
Copy link
Member Author

, is a valid character in filename, so it will cause problems. Actually, the only usable characters were : and |. But since : is already used for drive letters, I went with |.

se35710 pushed a commit to se35710/scoop that referenced this pull request Mar 8, 2022
@rashil2000 @se35710
fix(scoop-info): Use pipe to separate bins (ScoopInstaller#4744)
f2fafc3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rashil2000 @niheaven