-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(scoop-cat): Use bat
to pretty-print JSON
#4742
Conversation
Will it really matter? We just show one json file at a time, which is hardly 2-3KB (in worst case)
I can't find any docs on them. How to use them?
Haha yes, I forgot that I had a bat config file. |
If it looks the same, why use For the speed, in my PC (i5-8500/32G),
I mean add new config option to switch the background |
Grid lines and splits are useful for git output and multiple files. I suppose line numbers are useful, but I don't like them personally. My terminal is showing colors (notice the escaped backslashes). I'm using --theme=ansi (because it works in both light and dark terminals).
I think I have a genius solution to both these problems: a config variable called
How does that sound? |
And BTW, it should be named |
I'm not sure if we should do this automatically. What if the user doesn't have internet, and just wants to see local manifests? Downloading something for a local functionality seems bad. We can just detect if doesn't exist and use the normal Write-Output in that case.
To stick with a convention, I think we should use small case and underscores from now on. |
Just like For the ones that don't have Internet access, why they want to set Treat it just as existed ones, e.g., |
aria2 and lessmsi are used for downloading and installing apps, which automatically needs internet connection. I'm against the idea of making an offline functionality require being "online" (even if it's just one time setup). In the config, I will mention that bat is mandatory if the bat_style option is set (I will also mention in the docs that |
Okay, that works fine. Besides, if user has |
I was initially going for enabled by default, but as you mentioned that bat might be slow on some PCs, we should make it manually enabled. |
Okay, please make changes and I'll review again. |
Done |
Hmm, could you please separate config underscores to another PR? |
Okay sure |
This reverts commit 46524fc.
Co-authored-by: Hsiao-nan Cheung <niheaven@gmail.com>
* feat(scoop-cat): Use `bat` to pretty-print JSON * update changelog * hide filename and line numbers * Add `cat_style` config option * use underscores * Revert "use underscores" This reverts commit 46524fc. * Apply suggestions from code review Co-authored-by: Hsiao-nan Cheung <niheaven@gmail.com> Co-authored-by: Hsiao-nan Cheung <niheaven@gmail.com>
Description
Silly new feature of scoop-cat 🤣
Motivation and Context
Your manifest looks cute now xD
How Has This Been Tested?
Before
After
Checklist: