Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scoop-update): Enforce $null array #4725

Merged
merged 2 commits into from
Feb 9, 2022
Merged

fix(scoop-update): Enforce $null array #4725

merged 2 commits into from
Feb 9, 2022

Conversation

niheaven
Copy link
Member

@niheaven niheaven commented Feb 9, 2022

Description

Hotfix for #4720

If Get-Dependency() output $null, (Get-Dependency $app $architecture) -ne $app gives $false while @(Get-Dependency $app $architecture) -ne $app gives $null which is needed to ensure_none_failed()

Also some small fixes.

Motivation and Context

Relates to #4720

How Has This Been Tested?

Before:

image

After:

image

Checklist:

  • I have read the Contributing Guide.
  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.

@niheaven niheaven merged commit c01960f into develop Feb 9, 2022
@niheaven niheaven deleted the temp-fix branch February 9, 2022 10:27
se35710 pushed a commit to se35710/scoop that referenced this pull request Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant