Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(scoop-list): Show last-updated time #4723

Merged
merged 3 commits into from
Feb 9, 2022
Merged

feat(scoop-list): Show last-updated time #4723

merged 3 commits into from
Feb 9, 2022

Conversation

rashil2000
Copy link
Member

Description

Include an "Updated" field in the list, so users can sort it by most-recently updated apps.

Note: By default, if an object has more than 4 properties, PowerShell shows it as a 'List' instead of 'Table'. So a custom format file is needed to retain the Table here.

Motivation and Context

Closes #3777

Relates to #4718

How Has This Been Tested?

image

image

Checklist:

  • I have read the Contributing Guide.
  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.

@rashil2000
Copy link
Member Author

@niheaven how to detect if a manifest is user-generated? If it's a one-line change I can include it in this PR (and update the title).

@niheaven
Copy link
Member

niheaven commented Feb 8, 2022

Likes in my screenshot, the manifest is installed from a folder called workspace which contains all user generated manifests.

You could try it by scoop install ag@2.2.4 and see scoop list ag. This should work, but I'm not near a Windows machine to test it.

This type of installation is always hold, since the generated manifest will never be updated and scoop update ag doesn't work here 'cos its source never change.

@rashil2000
Copy link
Member Author

rashil2000 commented Feb 8, 2022

I added the Auto-generated part, but I think the Source should still point to the bucket from where the manifest was generated. The workspace path is an internal Scoop detail and shouldn't be exposed to users.

Any way to know from where (i.e. which bucket) the custom manifest was generated?

@niheaven
Copy link
Member

niheaven commented Feb 8, 2022

Nope, scoop cannot know the original bucket except for an app search (just like the way scoop find app, by searching all local buckets).

You could mask the manifest by using Generated as Source instead of add a info tag.

@rashil2000
Copy link
Member Author

Done

Copy link
Member

@niheaven niheaven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants