perf(install): Avoid checking all files for unlink persisted data #4681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You should add a CHANGLOG entry, thanks. and I'm on vacation soon, so the reviewing time may be longer. |
|
Sorry for late replying, I will add it. |
|
Forget to mention after changelog updated 🥲 . All things looks right now. Could you merge this? @niheaven |
niheaven
previously approved these changes
Feb 24, 2022
niheaven
previously approved these changes
Feb 24, 2022
rashil2000
reviewed
Feb 24, 2022
|
LGTM |
Co-authored-by: Rashil Gandhi <46838874+rashil2000@users.noreply.github.com>
niheaven
approved these changes
Feb 25, 2022
niheaven
changed the title
niheaven
added a commit
that referenced
this pull request
Feb 26, 2022
niheaven
added a commit
that referenced
this pull request
Feb 26, 2022
se35710
pushed a commit
to se35710/scoop
that referenced
this pull request
Mar 8, 2022
se35710
pushed a commit
to se35710/scoop
that referenced
this pull request
Mar 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
My commit involved two changes:
when uninstall or reset , avoid checking all files for unlink persisted data in function
unlink_persist_data. It will take a long time to check all the files when the contains a great deal of files by itself or would produce many new file in the daily usage. For example:miniconda3andanaconda3kick in above two situation and would produce many new hard-link file when installing new environments.when shim, add
-CommandType:Applicationoption togit. This is not that vital but it could cause problem ifgitis defined as apowershellfunction by user like meMotivation and Context
How Has This Been Tested?
I reset all my scoop apps (every kinds of app from every kinds of bucket, 482 apps in total), and the whole process worked well.
Checklist: