Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cleanup): Remove apps other than current version #4665

Merged
merged 3 commits into from
Jan 18, 2022
Merged

Conversation

niheaven
Copy link
Member

@niheaven niheaven commented Jan 17, 2022

Description

It will remove all subdir except for current and its target version.

Motivation and Context

Closes #4663

How Has This Been Tested?

Before:
image

After:
image

Checklist:

  • I have read the Contributing Guide.
  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.

@rashil2000
Copy link
Member

@zhangchaoza can you confirm if this fixes your issue?
To test this, temporarily switch to the PR branch:

scoop config SCOOP_BRANCH fix-cleanup
scoop update
scoop cleanup *

To go back to the stable (release) branch:

scoop config SCOOP_BRANCH master
scoop update

@niheaven niheaven marked this pull request as draft January 17, 2022 07:57
@niheaven
Copy link
Member Author

I'll change the logic to resolve #4648 (comment)

@zhangchaoza
Copy link

@zhangchaoza can you confirm if this fixes your issue? To test this, temporarily switch to the PR branch:

scoop config SCOOP_BRANCH fix-cleanup
scoop update
scoop cleanup *

To go back to the stable (release) branch:

scoop config SCOOP_BRANCH master
scoop update

It works, and thank you for your working.@niheaven

@niheaven niheaven marked this pull request as ready for review January 17, 2022 11:15
@niheaven niheaven changed the title fix(cleanup): Remove old duplicated versions fix(cleanup): Remove apps other than current version Jan 17, 2022
@niheaven
Copy link
Member Author

@zhangchaoza I'm sorry, but could you test this PR again? I've changed the logic.

Also pin @HUMORCE

@HUMORCE
Copy link
Member

HUMORCE commented Jan 17, 2022

failed installations can be removed with scoop-cleanup now. and i think scoop-list should be split for installed and failed apps, after these changes. OR just replace Installed apps: with Managed apps:

@niheaven niheaven merged commit 4e64db7 into develop Jan 18, 2022
@niheaven niheaven deleted the fix-cleanup branch January 18, 2022 06:25
se35710 pushed a commit to se35710/scoop that referenced this pull request Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants