Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(compress): Allow 'Expand-InnoArchive -ExtractDir' to accept '{xxx}' #3487

Merged
merged 1 commit into from
May 30, 2019
Merged

feat(compress): Allow 'Expand-InnoArchive -ExtractDir' to accept '{xxx}' #3487

merged 1 commit into from
May 30, 2019

Conversation

niheaven
Copy link
Member

@niheaven niheaven commented May 30, 2019 •
edited
Loading

ref: #3466 (comment)

Now freedownloadmanager's installer.script should be simplified to (see ScoopInstaller/Extras#2220)

"installer": {
    "script": [
        "Expand-InnoArchive -Path \"$dir\\$fname\"",
        "Expand-InnoArchive -Path \"$dir\\$fname\" -ExtractDir '{code_CefInstallDir}' -Removal"
    ]
}

@niheaven niheaven mentioned this pull request May 30, 2019
Merged
Ash258
Ash258 reviewed May 30, 2019
View reviewed changes
Copy link
Contributor

@Ash258 Ash258 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I am not sure how reliable would be to depend on curly brackets. But fur current use cases this is enough.

lib/decompress.ps1 Show resolved Hide resolved
@niheaven
Copy link
Member Author

I've tested for freedownloadmanager, and it works fine. See attached PR.

@r15ch13 r15ch13 changed the title feat(compress): Allow 'Expand-InnoArchive''s 'ExtractDir' to accept '{xxx}' feat(compress): Allow 'Expand-InnoArchive -ExtractDir' to accept '{xxx}' May 30, 2019
@r15ch13 r15ch13 merged commit 81e3cf6 into ScoopInstaller:develop May 30, 2019
r15ch13 pushed a commit that referenced this pull request Jun 24, 2019
@niheaven @r15ch13
feat(compress): Allow 'Expand-InnoArchive -ExtractDir' to accept '{xx…
1caaed8 
…x}' (#3487)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ash258 Ash258 Ash258 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@niheaven @Ash258 @r15ch13