Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scoop installs 7-Zip even when 7ZIPEXTRACT_USE_EXTERNAL is true #3700

Closed
TheRandomLabs opened this issue Oct 20, 2019 · 6 comments
Closed

Scoop installs 7-Zip even when 7ZIPEXTRACT_USE_EXTERNAL is true #3700

TheRandomLabs opened this issue Oct 20, 2019 · 6 comments

Comments

@TheRandomLabs
Copy link

If Expand-7ZipArchive is detected in the installer script, 7-Zip is installed even when 7ZIPEXTRACT_USE_EXTERNAL is set to true.

@TheRandomLabs
Copy link
Author

TheRandomLabs commented Oct 20, 2019

Changing this line to the following seems to fix this, but I don't know if it's the right way to do it:

if (!(get_config 7ZIPEXTRACT_USE_EXTERNAL) -and ($script -like '*Expand-7zipArchive *' -or $script -like '*extract_7zip *')) {

niheaven added a commit to niheaven/scoop that referenced this issue Oct 22, 2019
@TheRandomLabs
Copy link
Author

I've also noticed that here, 7zip-zstd is used even when 7ZIPEXTRACT_USE_EXTERNAL is set to false. Should this behavior not be made consistent?
Relevant lines

@rashil2000
Copy link
Member

@niheaven has the fix for this landed in master?

@niheaven
Copy link
Member

Not yet, it is fixed in #3502 which needs some rebasing onto current 'develop'.

@bc-185
Copy link

bc-185 commented Dec 4, 2021

What about creating a pull request for this?

@rashil2000
Copy link
Member

Closed in #4638

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants