fix(bucket): Return empty list correctly in Get-LocalBucket

CHANGELOG.md

@@ -14,6 +14,7 @@
 - **update:** Skip logs starting with `(chore)` ([#4800](https://github.com/ScoopInstaller/Scoop/issues/4800))
 - **scoop-download:** Add failure check ([#4822](https://github.com/ScoopInstaller/Scoop/pull/4822))
 - **install:** Fix issue with installation inside containers ([#4837](https://github.com/ScoopInstaller/Scoop/pull/4837))
+- **bucket:** Return empty list correctly in `Get-LocalBucket` ([#4885](https://github.com/ScoopInstaller/Scoop/pull/4885))
 
 ### Performance Improvements
 

lib/buckets.ps1

@@ -58,8 +58,11 @@ function Get-LocalBucket {
     .SYNOPSIS
         List all local buckets.
     #>
-
-    return (Get-ChildItem -Directory $bucketsdir).Name
+    $bucketNames = (Get-ChildItem -Directory $bucketsdir).Name
+    if (!$bucketNames.Length) {
+        return @() # Return a zero-length list instead of $null.
+    }
+    return $bucketNames
 }
 
 function buckets {
@@ -123,7 +126,12 @@ function Convert-RepositoryUri {
 
 function list_buckets {
     $buckets = @()
-    Get-LocalBucket | ForEach-Object {
+    $bucketNames = Get-LocalBucket
+    if (!$bucketNames.Length){
+        warn "No bucket found. Please run 'scoop bucket add main' to add the default 'main' bucket."
+        return
+    }
+    $bucketNames | ForEach-Object {
         $bucket = [Ordered]@{ Name = $_ }
         $path = Find-BucketDirectory $_ -Root
         if ((Test-Path (Join-Path $path '.git')) -and (Get-Command git -ErrorAction SilentlyContinue)) {

libexec/scoop-alias.ps1

@@ -94,7 +94,7 @@ function list_aliases {
     }
 
     if (!$aliases.count) {
-        warn 'No aliases founds.'
+        info "No alias found."
     }
     $aliases = $aliases.GetEnumerator() | Sort-Object Name
     if ($verbose) {

libexec/scoop-cache.ps1

@@ -24,9 +24,13 @@ function cacheshow($app) {
         $app = '(' + ($app -join '|') + ')'
     }
     $files = @(Get-ChildItem $cachedir | Where-Object -Property Name -Value "^$app#" -Match)
-    $totalLength = ($files | Measure-Object -Property Length -Sum).Sum
 
-    $files | ForEach-Object { cacheinfo $_ } | Select-Object Name, Version, Length, URL
+    if (!$files.Length) {
+        $totalLength = 0
+    } else {
+        $totalLength = ($files | Measure-Object -Property Length -Sum).Sum
+        $files | ForEach-Object { cacheinfo $_ } | Select-Object Name, Version, Length, URL
+    }
 
     Write-Host "Total: $($files.Length) $(pluralize $files.Length 'file' 'files'), $(filesize $totalLength)" -ForegroundColor Yellow
 }