Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xtensa-esp32-elf: Rename into xtensa-esp-elf #5463

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

pembem22
Copy link

  • xtensa-esp32/esp32s2/esp32s3-elf were unified into xtensa-esp-elf, see the release notes.

  • Update manifest accordingly.

  • I have read the Contributing Guide.

@pembem22
Copy link
Author

/verify

Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

xtensa-esp-elf

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

@tech189
Copy link
Member

tech189 commented Mar 4, 2024

We should try to avoid renaming manifests as users might get stuck on the old one and not realise that their app is no longer being updated (there is no current way to migrate users to the updated name). I feel like this may be too minor a name change to warrant a rename. Especially as all the binaries are still xtensa-esp32*-elf anyway. What do you think @HUMORCE?

@tech189 tech189 requested a review from rasa March 11, 2024 12:36
Copy link
Member

@rasa rasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should try to avoid renaming manifests as users might get stuck on the old one and not realise that their app is no longer being updated (there is no current way to migrate users to the updated name). I feel like this may be too minor a name change to warrant a rename. Especially as all the binaries are still xtensa-esp32*-elf

@tech189 @pembem22 I would tend to agree. If we need to rename, then add a new manifest, but add a note/suggests to the old one that a rename is in the works, to give the user some sort of warning, and timeline for the rename.

Or even better, a note in the original file that says what a better name for the manifest is. And then enhance our search tools to search in the notes field for this info? Or better yet, add an aliases field.

@HUMORCE
Copy link
Member

HUMORCE commented Mar 12, 2024

Scoop Core does not provide features like aliases, indicating alternatives, or disabling manifests, currently. I would prefer to add a deadline and announcement to notes of the original manifest and keep its functions (autoupdate, etc.), then create a new one.

ScoopInstaller/Extras#11116 ScoopInstaller/Extras#11171 And a manifest that is plagued by name changes: https://github.com/ScoopInstaller/Extras/pulls?q=is%3Apr+foxit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants