-
-
Notifications
You must be signed in to change notification settings - Fork 977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xtensa-esp32-elf: Rename into xtensa-esp-elf #5463
base: master
Are you sure you want to change the base?
Conversation
/verify |
All changes look good. Wait for review from human collaborators. xtensa-esp-elf
|
We should try to avoid renaming manifests as users might get stuck on the old one and not realise that their app is no longer being updated (there is no current way to migrate users to the updated name). I feel like this may be too minor a name change to warrant a rename. Especially as all the binaries are still |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should try to avoid renaming manifests as users might get stuck on the old one and not realise that their app is no longer being updated (there is no current way to migrate users to the updated name). I feel like this may be too minor a name change to warrant a rename. Especially as all the binaries are still
xtensa-esp32*-elf
@tech189 @pembem22 I would tend to agree. If we need to rename, then add a new manifest, but add a note/suggests to the old one that a rename is in the works, to give the user some sort of warning, and timeline for the rename.
Or even better, a note in the original file that says what a better name for the manifest is. And then enhance our search tools to search in the notes field for this info? Or better yet, add an aliases
field.
Scoop Core does not provide features like aliases, indicating alternatives, or disabling manifests, currently. I would prefer to add a deadline and announcement to ScoopInstaller/Extras#11116 ScoopInstaller/Extras#11171 And a manifest that is plagued by name changes: https://github.com/ScoopInstaller/Extras/pulls?q=is%3Apr+foxit |
xtensa-esp32/esp32s2/esp32s3-elf were unified into xtensa-esp-elf, see the release notes.
Update manifest accordingly.
I have read the Contributing Guide.