Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HashCheck: Add version 2.4.0 #2070

Merged
merged 2 commits into from
May 1, 2019
Merged

HashCheck: Add version 2.4.0 #2070

merged 2 commits into from
May 1, 2019

Conversation

niheaven
Copy link
Member

@niheaven niheaven commented Apr 29, 2019 •
edited
Loading

@niheaven niheaven mentioned this pull request Apr 29, 2019
Merged
@niheaven niheaven changed the title Add hashcheck HashCheck: Add version 2.4.0 Apr 29, 2019
@niheaven niheaven mentioned this pull request Apr 29, 2019
Open
6 tasks
r15ch13 pushed a commit to ScoopInstaller/Scoop that referenced this pull request Apr 29, 2019
@niheaven @r15ch13
Patch(decompress): Allow other args to be passthrough (#3411)
34c26aa 
ref: ScoopInstaller/Extras#2021 (comment), #3204 (comment)

- Add new param `Overwrite` to `Expand-7ZipArchive`, with following values
  - "All": 7z param `-aoa`, overwrite All existing files without prompt, behave the same with default
  - "Skip": 7z param `-aos`, Skip extracting of existing files
  - "Rename": 7z param `-aou`, aUto rename extracting file
- Add new param `Switches` to `Expand-7ZipArchive` and `Expand-InnoArchive`
  - It could pass all unrecognized params to `7z` and `innounp`
- Patch `extract_7zip` and `unpack_inno` to adapt to `Expand-XXX`

Usage: ScoopInstaller/Extras#2021, ScoopInstaller/Extras#2070
@indrakaw
Copy link

indrakaw commented May 1, 2019

HashCheck required administrator to modify registry for context menu options. Instead having to sudo on installation, why don't you do like VSCodium done?

https://github.com/lukesampson/scoop-extras/blob/master/bucket/vscodium.json

@niheaven
Copy link
Member Author

niheaven commented May 1, 2019

  • Property page is added by register DLL.
  • Context menu is the only entrance of HashCheck, no need to ask user run reg or sth. else themselves.
  • Why use this app without proper privilege? There are many cli checksum tools...

@indrakaw
Copy link

indrakaw commented May 1, 2019

I haven't see the executable binnary yet. Would you please add it to bin so it available on cmd?

@niheaven
Copy link
Member Author

niheaven commented May 1, 2019

There is no binary for HashCheck, only Property page dll. If you prefer cli tools, please consider dirhash or shasum.

@r15ch13 r15ch13 merged commit 6cc5816 into ScoopInstaller:master May 1, 2019
@niheaven niheaven deleted the add-hashcheck branch May 6, 2019 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Request hashcheck.
3 participants
@niheaven @indrakaw @r15ch13