Skip to content

wpsoffice: Update to version 12.2.0.21179, remove checkver#16564

Merged
z-Fng merged 3 commits intoScoopInstaller:masterfrom
useribs:master
Nov 17, 2025
Merged

wpsoffice: Update to version 12.2.0.21179, remove checkver#16564
z-Fng merged 3 commits intoScoopInstaller:masterfrom
useribs:master

Conversation

@useribs
Copy link
Copy Markdown
Contributor

@useribs useribs commented Nov 9, 2025

This was the latest version i was able to adjust to without much hassle, in 23155 they've changed and seemingly obfuscated where the binaries are kept,

Summary by CodeRabbit

  • Chores
    • Updated WPS Office to version 12.2.0.21179 and refreshed the installer package.
    • Package metadata and integrity information updated to match the new release.
    • App description, homepage, license, pre-install steps, installed shortcuts and runtime behavior remain unchanged.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Nov 9, 2025

Walkthrough

WPSOffice manifest updated: version, url, and hash changed to the new release (12.2.0.21179); the checkver block was removed; the autoupdate block remains and now references the new version pattern. Other manifest fields unchanged.

Changes

Cohort / File(s) Summary
WPSOffice manifest
bucket/wpsoffice.json
version bumped to 12.2.0.21179; url updated to the 12.2.0.21179 installer; hash replaced with the new SHA256; removed checkver block; autoupdate retained and references the new $version; other fields unchanged.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Verify version, url, and hash match the intended release artifacts.
  • Confirm removal of checkver is intentional and that autoupdate still works with the new URL pattern.
  • If installer extraction or packaging changed (see linked issue), validate installation still succeeds on target platforms.

Poem

🐰 I hopped through manifests bright and spry,
A version nudged up toward the sky,
URLs and hashes set anew,
Autoupdate tuned to follow through,
A little rabbit's update cry.

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Description check ❓ Inconclusive The PR description references the linked issue and explains the rationale for the update, but doesn't follow the repository's contribution template structure. Consider adding the linked issue reference using the 'Closes #XXXX' format from the template and confirming conventional title format adherence.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The PR title accurately describes the two main changes: updating wpsoffice to version 12.2.0.21179 and removing the checkver field.
Linked Issues check ✅ Passed The PR addresses issue #16565 by pinning to the last working version (12.2.0.21179) and removing the broken checkver, which aligns with the repository's precedent of pinning packages when vendor changes prevent extraction.
Out of Scope Changes check ✅ Passed All changes are narrowly scoped to the wpsoffice manifest: version bump, URL update, hash change, and checkver removal—all directly addressing the vendor-caused installation failure.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3d60f00 and 94fb565.

📒 Files selected for processing (1)
  • bucket/wpsoffice.json (1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: o-l-a-v
Repo: ScoopInstaller/Extras PR: 16378
File: bucket/compactgui.json:20-22
Timestamp: 2025-10-19T13:58:23.389Z
Learning: In the ScoopInstaller/Extras repository, the CompactGUI manifest removed hash verification from the autoupdate block because the hash verification mechanism (scraping SHA-256 from release page HTML) is no longer available in newer CompactGUI releases. GitHub asset digests exist in beta releases but not in v3.8.0, and Scoop doesn't have built-in support for extracting from GitHub API asset digests.
Learnt from: Gitoffthelawn
Repo: ScoopInstaller/Extras PR: 16106
File: bucket/czkawka-gui.json:25-25
Timestamp: 2025-09-05T09:41:52.653Z
Learning: For czkawka-gui manifests in Scoop Extras, the correct upstream filename pattern for Windows GUI builds in recent versions uses "gtk46" (without underscore), not "gtk_46" (with underscore). The autoupdate URL should use "windows_czkawka_gui_gtk46.zip" format. This was confirmed by a working 10.0.0 update with valid hash.
🔇 Additional comments (1)
bucket/wpsoffice.json (1)

2-2: Verify that the URL and hash correspond to a valid, working installer.

Please confirm:

  1. The URL at line 9 is accessible and points to a valid WPSOffice installer.
  2. The SHA-256 hash at line 10 correctly matches the downloaded executable.
  3. The existing pre_install extraction steps (lines 11–16) still successfully extract required binaries from this version without errors or corruption.

Given that the PR notes the vendor changed the installer format in newer versions, it's critical to verify that version 12.2.0.21179 remains compatible with the current extraction logic before merging.

Also applies to: 9-10


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 9, 2025

Your changes did not pass all checks.

Please address the issues in the manifest and comment starting with /verify to rerun the checks.

wpsoffice

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

@useribs
Copy link
Copy Markdown
Contributor Author

useribs commented Nov 9, 2025

Yeah, did not touch auto-update mechanics, their page is not uptodate

@useribs
Copy link
Copy Markdown
Contributor Author

useribs commented Nov 9, 2025

/verify this

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 9, 2025

All changes look good.

Wait for review from human collaborators.

wpsoffice

  • Lint
  • Description
  • License
  • Hashes

Check the full log for details.

@useribs useribs mentioned this pull request Nov 9, 2025
3 tasks
@Lutra-Fs
Copy link
Copy Markdown
Member

Lutra-Fs commented Nov 12, 2025

If we do not have enough resources to provide autoupdate and checkver, maybe it is better to deprecate this manifest instead of only removing the checkver and autoupdate. Any thoughts on this @z-Fng?

@z-Fng
Copy link
Copy Markdown
Member

z-Fng commented Nov 17, 2025

If we do not have enough resources to provide autoupdate and checkver, maybe it is better to deprecate this manifest instead of only removing the checkver and autoupdate. Any thoughts on this @z-Fng?

I'm also confused about how this situation should be handled. Howerver, to keep things moving, I'll continue handling the existing PRs according to the current mechanism until we reach a conclusion in our discussion.

We generally don't deprecate a package unless the package cannot be obtained at all.

For widely-used packages, sometimes we even retrieve them from web.archive.org.

@z-Fng z-Fng changed the title wpsoffice: update to version 12.2.0.21179 wpsoffice: Update to version 12.2.0.21179, remove checkver Nov 17, 2025
@z-Fng z-Fng merged commit 5ef0fd4 into ScoopInstaller:master Nov 17, 2025
3 checks passed
@z-Fng z-Fng mentioned this pull request Nov 17, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: wpsoffice no longer installs

3 participants