wpsoffice: Update to version 12.2.0.21179, remove checkver#16564
wpsoffice: Update to version 12.2.0.21179, remove checkver#16564z-Fng merged 3 commits intoScoopInstaller:masterfrom
Conversation
WalkthroughWPSOffice manifest updated: Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🧰 Additional context used🧠 Learnings (1)📓 Common learnings🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Your changes did not pass all checks. Please address the issues in the manifest and comment starting with wpsoffice
|
|
Yeah, did not touch auto-update mechanics, their page is not uptodate |
|
/verify this |
|
All changes look good. Wait for review from human collaborators. wpsoffice
|
|
If we do not have enough resources to provide autoupdate and checkver, maybe it is better to deprecate this manifest instead of only removing the checkver and autoupdate. Any thoughts on this @z-Fng? |
I'm also confused about how this situation should be handled. Howerver, to keep things moving, I'll continue handling the existing PRs according to the current mechanism until we reach a conclusion in our discussion.
|
This was the latest version i was able to adjust to without much hassle, in 23155 they've changed and seemingly obfuscated where the binaries are kept,
Summary by CodeRabbit