Skip to content

proton-pass: Add version 1.34.2#16260

Merged
z-Fng merged 6 commits intoScoopInstaller:masterfrom
zeldrisho:proton-pass
Mar 1, 2026
Merged

proton-pass: Add version 1.34.2#16260
z-Fng merged 6 commits intoScoopInstaller:masterfrom
zeldrisho:proton-pass

Conversation

@zeldrisho
Copy link
Contributor

@zeldrisho zeldrisho commented Oct 2, 2025

Closes #14390

Summary by CodeRabbit

  • New Features

    • Added Proton Pass (v1.34.2) to the app catalog for installation.
    • Creates a desktop/start menu shortcut labeled “Proton Pass”.
    • Enables automatic version checking and streamlined updates.
    • Verifies downloads with integrity checks.
  • Chores

    • Added app metadata (description, homepage, GPL-3.0-only license) to improve discoverability.

@coderabbitai
Copy link

coderabbitai bot commented Oct 2, 2025

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

Walkthrough

Adds a new Scoop manifest bucket/proton-pass.json for Proton Pass (v1.34.2) declaring metadata, 64-bit download with SHA-1, extract_dir lib\net45, a "Proton Pass" shortcut, checkver against version.json (Stable), and autoupdate templates including a RELEASES-based hash reference.

Changes

Cohort / File(s) Summary
Scoop manifest: Proton Pass
bucket/proton-pass.json
New manifest for version 1.34.2 with description, homepage, license GPL-3.0-only, 64-bit download and SHA-1 hash, extract_dir lib\net45, shortcut mapping ProtonPass.exe → "Proton Pass", checkver reading version.json (Stable) via JSONPath, and autoupdate templates for x64 download and RELEASES-based hash lookup.

Sequence Diagram(s)

sequenceDiagram
    autonumber
    actor User
    participant Scoop as "Scoop CLI"
    participant Manifest as "proton-pass.json"
    participant Server as "proton.me"
    participant OS as "System"

    User->>Scoop: scoop install proton-pass
    Scoop->>Manifest: read metadata (url_64, sha1, extract_dir, shortcut)
    Scoop->>Server: download installer (x64)
    Server-->>Scoop: installer binary
    Scoop->>Scoop: verify SHA-1
    Scoop->>OS: extract files to lib\net45
    OS-->>Scoop: files installed
    Scoop->>OS: create shortcut "Proton Pass" -> ProtonPass.exe

    User->>Scoop: scoop checkup / scoop update
    Scoop->>Manifest: fetch checkver (version.json) with JSONPath (Stable)
    Server-->>Scoop: version info (Stable)
    alt newer version available
        Scoop->>Manifest: construct autoupdate URL (x64)
        Scoop->>Server: fetch RELEASES for hash reference
    end
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested labels

review-needed

Suggested reviewers

  • aliesbelik

Poem

I hopped a patch into the bin,
Brought Proton Pass the latest win.
Hashes matched and shortcuts made,
Versions checked and autoupdate laid.
Rabbit dances — install parade. 🐇✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The PR description lacks the conventional PR title format and only partially completes the template. The required PR title checkbox is not properly addressed per the Contributing Guide requirements. Update the PR title or description to follow the conventional format: 'proton-pass[@1.34.2]: Add version 1.34.2' and ensure the PR title checkbox is explicitly addressed.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title 'proton-pass: Add version 1.34.2' directly summarizes the main change: adding a new Proton Pass package manifest at the specified version.
Linked Issues check ✅ Passed The PR adds a Proton Pass manifest (version 1.34.2) that meets all criteria from issue #14390: it's a well-known password manager meeting GitHub star and fork thresholds, uses standard installation methods, and represents the latest stable full version.
Out of Scope Changes check ✅ Passed The changeset contains only the new proton-pass.json manifest file addition, which is directly in scope for the linked issue's objective to add Proton Pass as a package.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2025

All changes look good.

Wait for review from human collaborators.

proton-pass

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

Copy link

@Hungonthose77 Hungonthose77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Share ❤️

@zeldrisho zeldrisho closed this Nov 7, 2025
@zeldrisho zeldrisho deleted the proton-pass branch November 7, 2025 07:01
@zeldrisho zeldrisho restored the proton-pass branch January 7, 2026 12:58
@zeldrisho zeldrisho reopened this Jan 7, 2026
@z-Fng z-Fng changed the title proton-pass: Add version 1.32.7 proton-pass: Add version 1.34.2 Mar 1, 2026
@ScoopInstaller ScoopInstaller deleted a comment from github-actions bot Mar 1, 2026
@ScoopInstaller ScoopInstaller deleted a comment from github-actions bot Mar 1, 2026
@z-Fng
Copy link
Member

z-Fng commented Mar 1, 2026

/verify

@github-actions
Copy link
Contributor

github-actions bot commented Mar 1, 2026

All changes look good.

Wait for review from human collaborators.

proton-pass

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

Copy link
Member

@z-Fng z-Fng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@z-Fng z-Fng merged commit 966cbf4 into ScoopInstaller:master Mar 1, 2026
3 checks passed
@zeldrisho zeldrisho deleted the proton-pass branch March 1, 2026 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Request]: proton-pass

3 participants