Re-enable web unit test #4444
Merged
Re-enable web unit test #4444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FirelightFlagboy
force-pushed
the
re-enable-web-unit-test
branch
from
f93a867
to
0774f3b
Compare
FirelightFlagboy
force-pushed
the
re-enable-web-unit-test
branch
from
94ded32
to
691bcff
Compare
mmmarcos
approved these changes
Apr 21, 2023
FirelightFlagboy
force-pushed
the
re-enable-web-unit-test
branch
from
66162db
to
063060d
Compare
FirelightFlagboy
force-pushed
the
reenable-web-ci
branch
from
15543dc
to
aa60c7b
Compare
FirelightFlagboy
force-pushed
the
re-enable-web-unit-test
branch
6 times, most recently
from
c75a97d
to
0ee8013
Compare
touilleMan
reviewed
Apr 24, 2023
| @@ -109,6 +111,9 @@ mod not_wasm32 { | |||
| } | |||
| } | |||
|
|
|||
| #[cfg(not(target_arch = "wasm32"))] | |||
| pub use not_wasm32::{HTTPS_PROXY, HTTP_PROXY}; | |||
There was a problem hiding this comment.
the names to use in platform are native and web
(don't use wasm32 given we specifically target web i.e. we consider we have access to the browser API)
FirelightFlagboy
force-pushed
the
re-enable-web-unit-test
branch
3 times, most recently
from
981a542
to
26b48c8
Compare
FirelightFlagboy
force-pushed
the
re-enable-web-unit-test
branch
from
26b48c8
to
d8b22fc
Compare
NicoTuxx
approved these changes
Apr 26, 2023
touilleMan
approved these changes
Apr 26, 2023
| @@ -1,80 +1,160 @@ | |||
| #! /usr/bin/env node | |||
|
|
|||
| const { argv, exit, platform } = require('node:process'); | |||
| const { spawnSync } = require('node:child_process'); | |||
| const { spawnSync, spawn } = require('node:child_process'); | |||
There was a problem hiding this comment.
No it isn't, all good now :)
Remove `wasm-pack` from `devDependencies` since it don't work. Instead install it from the wasm-pack repo. Other Changes ------------- - Correct unused warning when compiling `platform_http_proxy` on `wasm32`. - In `bindings/web/scripts/build.js`: - Provide `process.env` to sub command. - Now the script will directly invoque `wasm-pack`. - Ensure rust target `wasm32-unknown-unknown` is installed. - Ensure a link exist between `ci-rust` & `debug`. - Cache rust artifact when build the web bindings. Closes #4447
FirelightFlagboy
force-pushed
the
re-enable-web-unit-test
branch
from
d8b22fc
to
d27847a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
wasm-packfromdevDependenciessince it don't work.Instead install it from the wasm-pack repo.
Other Changes
platform_http_proxyonwasm32.bindings/web/scripts/build.js:process.envto sub command.wasm-pack.wasm32-unknown-unknownis installed.cibuild type for rust web sincewasm-packdon't support custom profile.Closes #4447