Skip to content

Commit

Permalink
Prevent using node > 18.13.0
Browse files Browse the repository at this point in the history
Currently our unit test started to fail because of a change introduced in node-18.13.0 (nodejs/node#46123).
So using a version before that change would correct the test that fail (#4071).

Changes
-------

- Change node-version in `ci.yml` to `18.12.0`
- Use github action `actions/setup-node` in `Web tests`
  • Loading branch information
FirelightFlagboy committed Feb 23, 2023
1 parent 7b9c126 commit b83ff6c
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 2 deletions.
7 changes: 6 additions & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,9 @@ on:
env:
python-version: "3.9"
rust-version: 1.66.1
node-version: 18.13.0
# We use the version 18.12 because the version >= 18.13 have some breaking changes on how they format the date.
# That would break our unit test if we don't update them.
node-version: 18.12.0
poetry-version: 1.2.2
# TODO: We stick to PostgreSQL 12 for the moment given later versions are
# much slower (postgresql tests runs in ~9mn on 12 vs ~36mn on 14 !)
Expand Down Expand Up @@ -428,6 +430,9 @@ jobs:
run: echo "run=true" >> $GITHUB_OUTPUT
shell: bash

- uses: actions/setup-node@8c91899e586c5b171469028077307d293428b516 # pin v3.5.1
with:
node-version: ${{ env.node-version }}
# TODO: cache libparsec and reuse it if Rust code hasn't changed !

- name: Install dependencies
Expand Down
4 changes: 3 additions & 1 deletion oxidation/client/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,9 @@
"wasm-pack": "^0.10.3"
},
"engines": {
"node": ">=16.13.0 <19.0.0"
"//": "We don't want to use node >= 18.13 because they've made some breaking changes on the Date formating.",
"//": "And that break our unit test. We better correct them when we bump the version of node that is compatible on all platform (web included)",
"node": ">=16.13.0 <18.13.0"
},
"description": "An Ionic project"
}

0 comments on commit b83ff6c

Please sign in to comment.