Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup & misc fixes #66

Merged
merged 13 commits into from
Apr 10, 2019
Merged

Cleanup & misc fixes #66

merged 13 commits into from
Apr 10, 2019

Conversation

sykhro
Copy link
Collaborator

@sykhro sykhro commented Mar 25, 2019 •
edited
Loading

  • Minimized copies
  • Fixed off-by-one errors
  • Fixed various compiler warnings
  • Fixed building under MSVC
  • gitignore'd our own .dat output
  • Added custom source code formatting command (based on the Google style)
  • Reformatted the source code
  • General housekeeping

@sykhro sykhro mentioned this pull request Apr 6, 2019
Merged
@GabrielePisciotta
Copy link
Member

This pull request fixes 1 alert when merging 8fcbe2d into cd4b913 - view on LGTM.com

fixed alerts:

  • 1 for Missing return statement

Comment posted by LGTM.com

@GabrielePisciotta
Copy link
Member

This pull request fixes 2 alerts when merging 1446970 into cd4b913 - view on LGTM.com

fixed alerts:

  • 2 for Missing return statement

Comment posted by LGTM.com

@sykhro sykhro changed the title Minor cleanup Cleanup & misc fixes Apr 6, 2019
@GabrielePisciotta
Copy link
Member

This pull request fixes 2 alerts when merging 4a27390 into cd4b913 - view on LGTM.com

fixed alerts:

  • 2 for Missing return statement

Comment posted by LGTM.com

@GabrielePisciotta
Copy link
Member

This pull request fixes 2 alerts when merging c8d85c2 into cd4b913 - view on LGTM.com

fixed alerts:

  • 2 for Missing return statement

Comment posted by LGTM.com

GabrielePisciotta
GabrielePisciotta requested changes Apr 10, 2019
View reviewed changes
Copy link
Member

@GabrielePisciotta GabrielePisciotta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes needed (follow previous messages about static analysis for return statements / exceptions)

@GabrielePisciotta
Copy link
Member

This pull request fixes 8 alerts when merging 32a3863 into 16194e2 - view on LGTM.com

fixed alerts:

  • 8 for Missing return statement

Comment posted by LGTM.com

@GabrielePisciotta
Copy link
Member

This pull request fixes 8 alerts when merging 472c920 into 16194e2 - view on LGTM.com

fixed alerts:

  • 8 for Missing return statement

Comment posted by LGTM.com

@GabrielePisciotta GabrielePisciotta merged commit 95c7abd into Scienza:dev Apr 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GabrielePisciotta GabrielePisciotta GabrielePisciotta requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sykhro @GabrielePisciotta