Styling review request & PR #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pandry
requested review from
AndreaIdini,
GabrielePisciotta and
mechanapoleon
Pandry
commented
Feb 14, 2019
| - readability > functionality, don't be afraid of writing 5 lines of code more | ||
| - Use namespaces, the name should be about the functionality itself | ||
| - **DO NOT** use `using` (e.g. `using namespace std;`) | ||
| - At the end of namespace, comment it's end `} // namespace nsName` |
There was a problem hiding this comment.
"its", but you can leave just "comment".
| - Align the equal sign when declaring multiple variables | ||
| - readability > functionality, don't be afraid of writing 5 lines of code more | ||
| - Use namespaces, the name should be about the functionality itself | ||
| - **DO NOT** use `using` (e.g. `using namespace std;`) |
There was a problem hiding this comment.
using is too generic
AndreaIdini
approved these changes
Feb 14, 2019
| - readability > functionality, don't be afraid of writing 5 lines of code more | ||
| - Use namespaces, the name should be about the functionality itself | ||
| - **DO NOT** use `using` (e.g. `using namespace std;`) | ||
| - At the end of namespace, comment it's end `} // namespace nsName` |
There was a problem hiding this comment.
"its", but you can leave just "comment".
| - Align the equal sign when declaring multiple variables | ||
| - readability > functionality, don't be afraid of writing 5 lines of code more | ||
| - Use namespaces, the name should be about the functionality itself | ||
| - **DO NOT** use `using` (e.g. `using namespace std;`) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Referring to issue #51