Skip to content

feat: add support for dbal v4 #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

simPod
Copy link
Contributor

@simPod simPod commented Feb 4, 2024

No description provided.

@simPod simPod force-pushed the dbal branch 6 times, most recently from c2abd65 to 2eb5dc2 Compare February 4, 2024 14:43
@simPod
Copy link
Contributor Author

simPod commented Feb 4, 2024

I think this will require too much work to get is working on unsupported php versions. I'm willing to implement this is we drop <8.2 php support.

@Hikariii
Copy link
Member

Hikariii commented Feb 5, 2024

Great suggestion! This needs a major version upgrade, removing older unsupported php versions.
Creating a 5.x branch and requiring php: ^8.1 support looks to me like the way forward.

@Hikariii
Copy link
Member

Hikariii commented Feb 5, 2024

I think this will require too much work to get is working on unsupported php versions. I'm willing to implement this is we drop <8.2 php support.

Dropping php 8.1 is too much for me, since php 8.1 is still supported by Doctrine 3 and dbal 4

@simPod
Copy link
Contributor Author

simPod commented Feb 7, 2024

Ok let me see what can be done.

@simPod simPod force-pushed the dbal branch 9 times, most recently from 8ec812d to 4eb866e Compare February 7, 2024 23:11
@simPod simPod marked this pull request as ready for review February 7, 2024 23:11
@simPod
Copy link
Contributor Author

simPod commented Feb 7, 2024

Tests were the worst. CI is green, WDYT?

@simPod simPod force-pushed the dbal branch 2 times, most recently from 443a8eb to 81e2d38 Compare February 8, 2024 09:54
@abozhinov
Copy link

When to expect the new release?

@derrabus derrabus mentioned this pull request Mar 4, 2024
@Hikariii
Copy link
Member

Hikariii commented Mar 8, 2024

When to expect the new release?

Release 5.5.0 supports orm 3

@Hikariii
Copy link
Member

Hikariii commented Mar 8, 2024

Tests were the worst. CI is green, WDYT?

Looks good, let me see if I can adopt and fix your work after a 5.x compatibility merge

@Hikariii Hikariii mentioned this pull request Mar 8, 2024
@Hikariii
Copy link
Member

Hikariii commented Mar 8, 2024

Closed because this is merged via #109

@Hikariii Hikariii closed this Mar 8, 2024
@simPod simPod deleted the dbal branch March 8, 2024 13:40
@simPod
Copy link
Contributor Author

simPod commented Mar 8, 2024

I'm not as a contributor in release notes at dbal 4 support 🤔 🙃 🫠

@Hikariii
Copy link
Member

I'm quite sure you are: b153ee2
It is a shared commit.

@simPod
Copy link
Contributor Author

simPod commented Mar 11, 2024

Release notes
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants