Add phpstan and fix some related issues #121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hikariii
force-pushed
the
chore/phpstan
branch
from
9b4c507 to
7b9673a
Compare
Fix compatibility issues with older composer versions Run phpstan in ci
Hikariii
force-pushed
the
chore/phpstan
branch
from
7b9673a to
8b3452b
Compare
luukvhoudt
requested changes
Oct 18, 2024
| if (class_exists('Doctrine\DBAL\Platforms\Exception\NotSupported')) { | ||
| return NotSupported::new($method); | ||
| return \Doctrine\DBAL\Platforms\Exception\NotSupported::new($method); |
There was a problem hiding this comment.
Because it is a backward compatibility class.
The complexity of supporting dbal3 and dbal4 requires this class to use fully qualified class names when dbal3 is used, because the class does not exist in dbal 3.
luukvhoudt
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix compatibility issues with older composer versions
Run phstan in ci