S1S2 target coverage target_validation.py#281
Open
max-tikehaucapital wants to merge 1 commit intoScienceBasedTargets:mainfrom
Open
S1S2 target coverage target_validation.py#281max-tikehaucapital wants to merge 1 commit intoScienceBasedTargets:mainfrom
max-tikehaucapital wants to merge 1 commit intoScienceBasedTargets:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
S1S2 targets are supposed to have coverage_s1=coverage_s2 (otherwise coverage_s2 is not required since only coverage_s1 is used to adjust the reduction_ambition). For example it is checked when converting a S1, S2, or S1S2S3 target into a S1S2 one. However it is not done when the target has scope S1S2, therefore I suggest to fix coverage_s1 and coverage_s2 to the weighted average of both previous coverages based on base year ghg emissions (this is what is done to convert targets into a S1S2 target). To do this I added a variable s1s2 in the validate method and create a method which implement this modification.