refactor(app): use in-app directory dialog for desktop project open/new - #1140
Open
Spin-Particle wants to merge 1 commit into
Open
refactor(app): use in-app directory dialog for desktop project open/new#1140Spin-Particle wants to merge 1 commit into
Spin-Particle wants to merge 1 commit into
Conversation
Desktop launched the native OS picker for open project and a separate new-project dialog whose browse button also spawned the native picker. Both entries now open the same in-app directory dialog as the web client (existing projects list, search, confirm, create missing folder), and the unused dialog-new-project component is removed. The native picker remains available via the browse button inside the dialog, same as web.
Spin-Particle
requested review from
code-JDS,
lixfrank,
shellmind112 and
yqmaphy
as code owners
August 19, 2026 03:31
Spin-Particle
force-pushed
the
feat/unify-project-dialog
branch
from
August 19, 2026 10:49
9fcf1f7 to
0ba2bac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #1139
Type of change
What does this PR do?
Desktop (Electron) diverged from web for project selection: "打开项目" went straight to the native OS directory picker (
platform.openDirectoryPickerDialogbranch inhome.tsxandlayout.tsx), and "新建项目" opened a separateDialogNewProjectwhose browse button spawned the same native picker via the server/file/pick-folderroute. Users on desktop therefore never saw the web dialog's recent-projects list, search, or create-missing-folder flow.This change removes the native-picker branches in
chooseProject(home page and layout sidebar/command palette) and pointsnewProjectat the sameDialogSelectDirectoryused by web (single-select, titled "新建项目"), so desktop and web now share one consistent dialog. The native OS picker stays available as auxiliary input through the dialog's existing "浏览" button, identical to web behavior. The now-unuseddialog-new-project.tsxis deleted; its i18ndialog.newProject.*keys remain becausedialog-select-directory.tsxreuses them for group headers.How did you verify your code works?
bun typecheckinpackages/apppasses.bun run testinpackages/app: 29 passed, 2 skipped (incl.sidebar-shell.vitest.tsx).Aether Desktop Devdmg) with the rebuilt sidecar CLI; confirmed the renderer bundle contains thedialog-select-directoryflow for home and no longer references the removed component.Screenshots / recordings
Not attached here; the target UI is identical to the existing web dialog shown in the issue discussion (browse + search + confirm row, "已有项目" / "新建项目" sections).
Checklist