Skip to content

Conversation

@trexfeathers
Copy link
Contributor

I now consider Mamba safe to use given the 1.0 release in late 2022. The implementation suggested here is more conventional / less surprising and that's always good.

I have confirmed in my own uses that Conda lock will default to using Mamba if it is available in the environment.

I believe this closes SciTools/iris#5139 - testing locally I am able to resolve the desired lock files by running conda-lock lock in an environment that also contains Mamba.

Not sure how to test that this action works as intended. Have we established any norms on this yet?

@trexfeathers trexfeathers requested a review from lbdreyer February 1, 2023 12:47
Copy link
Member

@lbdreyer lbdreyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that it is perfectly fine to use mamba now. After all, we have been using the conda-libmamba-solver which was only recently no longer deemed "experimental"
What confuses me however, is why conda-libmamba-solver was no longer working if that is using mamba's solver. Very odd!

Nonetheless using mamba directly make sense to me!

Unfortunately, we don't really have a convenient way of testing these workflows (at least not in the sense of a CI solution). In the past I tested it with a test repo that called the workflow from my own fork instead of upstream/main. If you have any suggestions please let me know!

@lbdreyer lbdreyer merged commit 6d72c47 into SciTools:main Feb 1, 2023
@pp-mo
Copy link
Member

pp-mo commented Feb 2, 2023

I know you guys just merged this, but I don't understand how it works ?

So, you removed conda-mamba-solver from the env used to solve, added mamba, and removed the 'CONDA_EXPERIMENTAL_SOLVER' control var.

But in that case, the basic command is still "conda-lock lock ...".
So, what makes that use mamba ??

@pp-mo
Copy link
Member

pp-mo commented Feb 2, 2023

IIUC, previously the env-var forced the use of the conda solver within basic conda operation.
But should we not now be saying mamba lock ... or something similar ??

@lbdreyer
Copy link
Member

lbdreyer commented Feb 2, 2023

But in that case, the basic command is still "conda-lock lock ...".
So, what makes that use mamba ??

conda-lock should use mamba if it is installed in the environment by default

@pp-mo
Copy link
Member

pp-mo commented Feb 3, 2023

But in that case, the basic command is still "conda-lock lock ...".
So, what makes that use mamba ??

conda-lock should use mamba if it is installed in the environment by default

Thanks, I had no idea.
I think I can see that from code now, though sadly their docs are all down now for some reason :-(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Lockfile action failed to resolve environment

3 participants