Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ci-template-check.yml #115

Merged
merged 1 commit into from
Mar 24, 2025
Merged

Conversation

trexfeathers
Copy link
Contributor

@trexfeathers trexfeathers commented Mar 20, 2025

See SciTools/.github#41 for the detailed context. Will need calling workflows on each of our repos.

Do we still believe in the workflows repository?

I personally have experienced a lot of frustrations of having one workflow that affects all repositories, as it gets in the way of me introducing a new concept (e.g. #28), means mistakes have large impacts (e.g. #88 vs #93), and makes it difficult to test things (e.g #108).

Templating is an alternative way of achieving the same thing, without the above problems. HOWEVER: we have agreed among the core devs that templating needs to be demonstrated to work BEFORE we apply it to workflows. In the meantime I felt it was important to embrace our current way of working.

Dependent PRs

@ESadek-MO
Copy link

All dependent PRs have now been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants