Skip to content

Adding a check-manifest GHA and updating dependent files #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 30, 2023
Merged

Adding a check-manifest GHA and updating dependent files #57

merged 5 commits into from
Mar 30, 2023

Conversation

@HGWright
Copy link
Contributor

@HGWright HGWright commented Mar 15, 2023 •
edited
Loading

Added a check-manifest GHA and updated the MANIFEST.in file and the pyproject.toml to match it.

closes #58 & #59

@HGWright HGWright linked an issue Mar 15, 2023 that may be closed by this pull request
Update MANIFEST.in #59
Closed
@HGWright HGWright requested a review from bjlittle March 15, 2023 16:56
bjlittle
bjlittle requested changes Mar 29, 2023
View reviewed changes
Copy link
Member

@bjlittle bjlittle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HGWright This is great, thanks for tidying this up 👍

However, I've got one suggestion up for discussion...

bjlittle
bjlittle reviewed Mar 30, 2023
View reviewed changes
@HGWright @bjlittle
Update MANIFEST.in
34359e4 
Co-authored-by: Bill Little <bill.little@metoffice.gov.uk>
bjlittle
bjlittle approved these changes Mar 30, 2023
View reviewed changes
Copy link
Member

@bjlittle bjlittle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HGWright Nice one, this looks good to me 😄

@bjlittle bjlittle merged commit a7427c6 into SciTools:master Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bjlittle bjlittle bjlittle approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update MANIFEST.in Add GHA MANIFEST checking

2 participants

@HGWright @bjlittle