Skip to content

Conversation

@bjlittle
Copy link
Member

This PR reinstates the .coveragerc file that I accidentally on purpose purged in #41 ☺️

Hopefully this will reinstate codecov test coverage metrics of cython .pyx files 🤞

@codecov
Copy link

codecov bot commented May 20, 2021

Codecov Report

Merging #43 (4d2b562) into master (6248316) will decrease coverage by 1.77%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #43      +/-   ##
==========================================
- Coverage   98.33%   96.56%   -1.78%     
==========================================
  Files           5        4       -1     
  Lines         480      320     -160     
  Branches        0        6       +6     
==========================================
- Hits          472      309     -163     
- Misses          8       11       +3     
Impacted Files Coverage Δ
stratify/tests/test_bounded_vinterp.py
stratify/tests/performance.py
stratify/tests/test_vinterp.py
stratify/_vinterp.pyx 95.29% <0.00%> (ø)
stratify/_conservative.pyx 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6248316...4d2b562. Read the comment docs.

@bjlittle
Copy link
Member Author

bjlittle commented May 20, 2021

Bingo 🎉 ... of course codecov is triggering a PR failure as its deemed coverage has regressed, but that's based on an unfair comparison i.e., previously .pyx files weren't included in its metrics and it's also excluding files that shouldn't have been included i.e., the tests themselves.

@bjlittle
Copy link
Member Author

I may now play with configuring codecov, rather than opting for the default behaviours...

@bjlittle
Copy link
Member Author

Closes #42

@bjlittle bjlittle requested a review from jamesp May 20, 2021 22:19
@bjlittle
Copy link
Member Author

bjlittle commented May 20, 2021

@jamesp Are you happy to roll with this PR as is? I think it's good to go 👍

@jamesp jamesp merged commit 37a63d8 into SciTools:master May 21, 2021
@bjlittle bjlittle deleted the cython-codecov branch April 25, 2023 20:23
@HGWright HGWright mentioned this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants