Skip to content

Conversation

@evertrol
Copy link
Contributor

I noticed a SyntaxWarning (not yet an error) when trying to run the tests with the Python 3.8 beta build. While 3.8 is still in beta, this does indeed appear to be a potential problem, and easy to avoid by using raw strings.

@coveralls
Copy link

coveralls commented Sep 12, 2019

Coverage Status

Coverage remained the same at 96.707% when pulling 4df9f8f on evertrol:syntax-correction into e75b4eb on SciTools-incubator:master.

@bjlittle
Copy link
Member

@evertrol Have you signed the CLA - It should have been automatically sent to you?

@evertrol
Copy link
Contributor Author

I saw the notice by the checker, but I feel for such a trivial change, a CLA should not be necessary (and, generally, implicit by submitting a PR).
Also, I'm technically not allowed to sign a CLA by my employer, and I would have to get another person (or several) involved, which seems unnecessary.

@bjlittle bjlittle merged commit f7befaa into SciTools:master Sep 13, 2019
@bjlittle
Copy link
Member

Nice one, thanks @evertrol 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants