Lock-files update plus stop decorating PyTest fixtures #6806
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
benchmark_this
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6806 +/- ##
=======================================
Coverage 90.39% 90.39%
=======================================
Files 91 91
Lines 24761 24761
Branches 4639 4639
=======================================
Hits 22382 22382
Misses 1608 1608
Partials 771 771 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
⏱️ Performance Benchmark Report: c30b35aPerformance shiftsFull benchmark resultsGenerated by GHA run |
pp-mo
requested changes
Nov 19, 2025
lib/iris/tests/test_plot.py
Outdated
| # Load example 4d data (TZYX). | ||
| test_cube = iris.tests.stock.realistic_4d() | ||
|
|
||
| @_shared_utils.skip_data |
Member
There was a problem hiding this comment.
It's not at all obvious to me that this actually works : Have you checked that running without testdata actually skips these tests ?
I guess this would work if pytest marking is actually based on exception raising, but that isn't my understanding of it ?
If it does work then I think, at the least, an explanation would be good!
Contributor
Author
There was a problem hiding this comment.
Agreed; this was very much a try-and-see. It did successfully skip/not-skip as expected. e842b14 is perhaps a clearer implementation, with an explanatory comment.
Contributor
⏱️ Performance Benchmark Report: 4a7ce4bPerformance shiftsFull benchmark resultsGenerated by GHA run |
pp-mo
approved these changes
Nov 21, 2025
Contributor
⏱️ Performance Benchmark Report: 3d57091Performance shiftsFull benchmark resultsGenerated by GHA run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
References
Consult Iris pull request check list
Add any of the below labels to trigger actions on this PR: