Skip to content

Conversation

@stephenworsley
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Oct 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.39%. Comparing base (863e2e3) to head (e7ec1f9).
⚠️ Report is 2 commits behind head on v3.14.x.

Additional details and impacted files
@@           Coverage Diff            @@
##           v3.14.x    #6780   +/-   ##
========================================
  Coverage    90.39%   90.39%           
========================================
  Files           91       91           
  Lines        24761    24761           
  Branches      4639     4639           
========================================
  Hits         22382    22382           
  Misses        1608     1608           
  Partials       771      771           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@trexfeathers trexfeathers merged commit 2b72e2c into SciTools:v3.14.x Oct 31, 2025
21 checks passed
Copy link
Member

@pp-mo pp-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor changes suggested.
Also not sure about status of the HDF fix -- but I agree it probably is worth highlighting.

And finally, get in touch with us on :issue:`GitHub<new/choose>` if you have
any issues or feature requests for improving Iris. Enjoy!
* Improved functionality of :ref:`dataless-cubes`. Dataless cubes were introduced in
Iris 3.12 with limited functionality, it is now possible to load, save and do the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

loading and saving dataless cubes is only possible with netCDF files.
It may be worth making that clear.


* N/A
* Added a convenience function :func:`~iris.util.make_gridcube` for creating
a 2D cube with a grid of a specified shape. This is useful for functions
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a grid of a specified shape

I think it would be better to say "a specified grid", since I guess users will almost always want to specify the actual X and Y points.

* Added the utility :func:`~iris.util.mask_cube_from_shape`, superceding
:func:`~iris.util.mask_cube_from_shapefile` and adding the ability to handle
shapefiles that use different coordinate systems to the cube they are being
applied to, adding the ability to handle additional Point and Line shape types
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
applied to, adding the ability to handle additional Point and Line shape types
applied to, the ability to handle additional Point and Line shape types

(i.e. cut out the second "adding")
I think this reads better, as you need to follow the continuity "adding the ability to <X>, the ability to <Y> and improving the performance."
Personally I would also attempt to put a comma before the final "and", but it's very debatable + many people positively dislike it!

================
* Various performance improvements including:

* Extending zlib compression to include `CF-UGRID`_ data.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Extending zlib compression to include `CF-UGRID`_ data.
* Extended zlib compression to include the variables of a `CF-UGRID`_ mesh.

First change : for consistency with the other bulleted statements
Second change : I think is more informative


* Prevented transient failures in parallelised NetCDF saving (caused by an HDF locking delay).

* Improved the memory-per-chunk resulting from regridding.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is specific to AreaWeighted?
If so, better to say so.

And finally, get in touch with us on :issue:`GitHub<new/choose>` if you have
any issues or feature requests for improving Iris. Enjoy!
* Improved functionality of :ref:`dataless-cubes`. Dataless cubes were introduced in
Iris 3.12 with limited functionality, it is now possible to load, save and do the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Iris 3.12 with limited functionality, it is now possible to load, save and do the
Iris 3.12 with limited functionality. It is now possible to load, save and do the

new sentence

#. N/A
* Improved NetCDF loading when constraining by multiple names.

* Prevented transient failures in parallelised NetCDF saving (caused by an HDF locking delay).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is important, and may be worth highlighting,
but it's not a performance improvement
it's a bugfix (sort-of) -- at least, it prevents errors, so I guess we can call it a "fix", or maybe a "workaround"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

3 participants