-
Notifications
You must be signed in to change notification settings - Fork 298
V3.14.x updates #6780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V3.14.x updates #6780
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v3.14.x #6780 +/- ##
========================================
Coverage 90.39% 90.39%
========================================
Files 91 91
Lines 24761 24761
Branches 4639 4639
========================================
Hits 22382 22382
Misses 1608 1608
Partials 771 771 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pp-mo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor changes suggested.
Also not sure about status of the HDF fix -- but I agree it probably is worth highlighting.
| And finally, get in touch with us on :issue:`GitHub<new/choose>` if you have | ||
| any issues or feature requests for improving Iris. Enjoy! | ||
| * Improved functionality of :ref:`dataless-cubes`. Dataless cubes were introduced in | ||
| Iris 3.12 with limited functionality, it is now possible to load, save and do the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
loading and saving dataless cubes is only possible with netCDF files.
It may be worth making that clear.
|
|
||
| * N/A | ||
| * Added a convenience function :func:`~iris.util.make_gridcube` for creating | ||
| a 2D cube with a grid of a specified shape. This is useful for functions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a grid of a specified shape
I think it would be better to say "a specified grid", since I guess users will almost always want to specify the actual X and Y points.
| * Added the utility :func:`~iris.util.mask_cube_from_shape`, superceding | ||
| :func:`~iris.util.mask_cube_from_shapefile` and adding the ability to handle | ||
| shapefiles that use different coordinate systems to the cube they are being | ||
| applied to, adding the ability to handle additional Point and Line shape types |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| applied to, adding the ability to handle additional Point and Line shape types | |
| applied to, the ability to handle additional Point and Line shape types |
(i.e. cut out the second "adding")
I think this reads better, as you need to follow the continuity "adding the ability to <X>, the ability to <Y> and improving the performance."
Personally I would also attempt to put a comma before the final "and", but it's very debatable + many people positively dislike it!
| ================ | ||
| * Various performance improvements including: | ||
|
|
||
| * Extending zlib compression to include `CF-UGRID`_ data. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| * Extending zlib compression to include `CF-UGRID`_ data. | |
| * Extended zlib compression to include the variables of a `CF-UGRID`_ mesh. |
First change : for consistency with the other bulleted statements
Second change : I think is more informative
|
|
||
| * Prevented transient failures in parallelised NetCDF saving (caused by an HDF locking delay). | ||
|
|
||
| * Improved the memory-per-chunk resulting from regridding. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is specific to AreaWeighted?
If so, better to say so.
| And finally, get in touch with us on :issue:`GitHub<new/choose>` if you have | ||
| any issues or feature requests for improving Iris. Enjoy! | ||
| * Improved functionality of :ref:`dataless-cubes`. Dataless cubes were introduced in | ||
| Iris 3.12 with limited functionality, it is now possible to load, save and do the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Iris 3.12 with limited functionality, it is now possible to load, save and do the | |
| Iris 3.12 with limited functionality. It is now possible to load, save and do the |
new sentence
| #. N/A | ||
| * Improved NetCDF loading when constraining by multiple names. | ||
|
|
||
| * Prevented transient failures in parallelised NetCDF saving (caused by an HDF locking delay). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is important, and may be worth highlighting,
but it's not a performance improvement
it's a bugfix (sort-of) -- at least, it prevents errors, so I guess we can call it a "fix", or maybe a "workaround"
No description provided.