-
Notifications
You must be signed in to change notification settings - Fork 296
Stricter array summary in CML output #6743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Add `checksum` to _DimensionalMetadata xml. - New `masked_count` attr added to cube and _DimensionalMetadata xml.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ukmo-ccbunney Lookin' good.
Just some initial comments to consider 👍
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6743 +/- ##
==========================================
- Coverage 90.29% 90.24% -0.06%
==========================================
Files 91 91
Lines 24475 24613 +138
Branches 4571 4604 +33
==========================================
+ Hits 22100 22212 +112
- Misses 1607 1624 +17
- Partials 768 777 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
A real-life case of CML protecting us, if you were interested: |
the setting if the keyword is non-None. This allows for nested context managers without loosing previous settings.
31cea83
to
537f121
Compare
Note modification of `unit/pandas/test_pandas.py` to disable coord checksum
537f121
to
95f3a42
Compare
The CML output for testing (generated from
No other formatting options have been enabled by default for the CML generation in the tests (such as Commit 95f3a42 covers all the updated CML files + one change to |
make CML_Settings public class so it appears in docs
BTW: 2 new CML outputs were added as part of 7791944 to provide test coverage or the new formatting options. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ukmo-ccbunney This is an impressively nimble refresh to some thorny historic code 🥇
Just a few minor observations to service, otherwise LGTM 👍
Fix typo Co-authored-by: Bill Little <bill.little@metoffice.gov.uk>
Fix docstring link Co-authored-by: Bill Little <bill.little@metoffice.gov.uk>
Co-authored-by: Bill Little <bill.little@metoffice.gov.uk>
Co-authored-by: Bill Little <bill.little@metoffice.gov.uk>
Co-authored-by: Bill Little <bill.little@metoffice.gov.uk>
Co-authored-by: Bill Little <bill.little@metoffice.gov.uk>
🚀 Pull Request
Closes: #6244
Description
Consult Iris pull request check list
Add any of the below labels to trigger actions on this PR: