-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add type hints to iris.cube.Cube
#6037
Conversation
8e55c61
to
f19dfbf
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6037 +/- ##
==========================================
- Coverage 89.82% 89.81% -0.01%
==========================================
Files 88 88
Lines 23150 23174 +24
Branches 5043 5045 +2
==========================================
+ Hits 20794 20814 +20
+ Misses 1624 1623 -1
- Partials 732 737 +5 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @bouweandela, thanks so much for this, sorry for the delay of getting a review up.
This all looks great to me, happy for this to go in. Would you be happy to resolve the merge conflict, and then I can merge this!
Thanks for reviewing @ESadek-MO! ✨ |
🚀 Pull Request
Description
Add type hints to
iris.cube.Cube
.Closes #5567
Consult Iris pull request check list
Add any of the below labels to trigger actions on this PR: