Skip to content

Revert SciTools/iris#5763 #5779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

trexfeathers
Copy link
Contributor

🚀 Pull Request

Description

#5776 shows promise but can't currently be demonstrated while the failed attempt at labelling is still present.


Consult Iris pull request check list

@trexfeathers trexfeathers changed the title Revert SciTools/iris#5776 Revert SciTools/iris#5763 Feb 23, 2024
@trexfeathers
Copy link
Contributor Author

trexfeathers commented Feb 23, 2024

@HGWright if you thought it better for traceability: we could keep the labeler action IN ADDITION to #5776? As we know, adding the label won't always actually trigger the benchmarks, but it would flag up anything that is being benchmarked via the alternative trigger!

Copy link

codecov bot commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.74%. Comparing base (8998779) to head (ed9fa4c).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5779   +/-   ##
=======================================
  Coverage   89.74%   89.74%           
=======================================
  Files          92       92           
  Lines       22940    22940           
  Branches     5462     5462           
=======================================
  Hits        20588    20588           
  Misses       1620     1620           
  Partials      732      732           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@trexfeathers
Copy link
Contributor Author

@HGWright if you thought it better for traceability: we could keep the labeler action IN ADDITION to #5776? As we know, adding the label won't always actually trigger the benchmarks, but it would flag up anything that is being benchmarked via the alternative trigger!

Closing after offline conversation

@trexfeathers trexfeathers deleted the undo_labeler branch May 3, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant