Iris to GeoVista conversion #5740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
trexfeathers
requested changes
Feb 13, 2024
There was a problem hiding this comment.
Good stuff @HGWright, here are some things to action when you have time
lib/iris/tests/unit/experimental/geobridge/test_cube_faces_to_polydata.py
Outdated
Show resolved
Hide resolved
lib/iris/tests/unit/experimental/geobridge/test_cube_faces_to_polydata.py
Outdated
Show resolved
Hide resolved
lib/iris/tests/unit/experimental/geobridge/test_cube_faces_to_polydata.py
Outdated
Show resolved
Hide resolved
lib/iris/tests/unit/experimental/geobridge/test_cube_faces_to_polydata.py
Outdated
Show resolved
Hide resolved
lib/iris/tests/unit/experimental/geobridge/test_cube_faces_to_polydata.py
Outdated
Show resolved
Hide resolved
trexfeathers
requested changes
Feb 13, 2024
for more information, see https://pre-commit.ci
This reverts commit dec4edb.
This reverts commit 0470dee.
trexfeathers
requested changes
Feb 19, 2024
lib/iris/tests/unit/experimental/geobridge/test_cube_faces_to_polydata.py
Outdated
Show resolved
Hide resolved
lib/iris/tests/unit/experimental/geobridge/test_region_extraction.py
Outdated
Show resolved
Hide resolved
trexfeathers
requested changes
Mar 27, 2024
lib/iris/tests/integration/experimental/geovista/test_cube_to_poly.py
Outdated
Show resolved
Hide resolved
lib/iris/tests/integration/experimental/geovista/test_cube_to_poly.py
Outdated
Show resolved
Hide resolved
lib/iris/tests/integration/experimental/geovista/test_extract_unstructured_region.py
Show resolved
Hide resolved
lib/iris/tests/unit/experimental/geovista/test_extract_unstructured_region.py
Show resolved
Hide resolved
pp-mo
reviewed
Mar 27, 2024
@trexfeathers contributions to SciTools#5740.
github-actions
bot
added
the
benchmark_this
|
BTW there also seems to be nothing in the API docs build for I've no idea why this is -- I'm assuming it should be showing API for Perhaps it's discovery behaves differently in "experimental", and perhaps an |
There's loads! |
Sorry, that was a browser caching thing ! |
trexfeathers
requested changes
Mar 27, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5740 +/- ##
==========================================
+ Coverage 89.74% 89.78% +0.03%
==========================================
Files 92 93 +1
Lines 22942 23004 +62
Branches 5464 5479 +15
==========================================
+ Hits 20590 20653 +63
Misses 1620 1620
+ Partials 732 731 -1 ☔ View full report in Codecov by Sentry. |
* 'geo-bridge' of github.com:HGWright/iris: (41 commits) Updated lock files. [pre-commit.ci] auto fixes from pre-commit.com hooks Advertise structured_um_loading performance regression. [pre-commit.ci] pre-commit autoupdate Updated environment lockfiles [pre-commit.ci] auto fixes from pre-commit.com hooks [pre-commit.ci] pre-commit autoupdate Make the bugfix panel OPEN. What's New patch. What's New patch. Bump scitools/workflows from 2024.03.1 to 2024.03.3 Bump scitools/workflows from 2024.03.0 to 2024.03.1 Bump scitools/workflows from 2024.02.2 to 2024.03.0 Fix usage of map_blocks in AreaWeighted and elsewhere (SciTools#5767) Lazy rolling_window (SciTools#5775) whatsnew update for 3.8.0 (SciTools#5793) Bump scitools/workflows from 2024.02.1 to 2024.02.2 (SciTools#5792) DOCS: Add whatsnew for recent PRs (SciTools#5789) ASV custom build command and file-based benchmark triggers (SciTools#5776) DOCS: Enable numpydoc validation pre-commit hook (SciTools#5762) ...
trexfeathers
approved these changes
Mar 27, 2024
⏱️ Performance Benchmark Report: ffe8571Performance shiftsFull benchmark resultsGenerated by GHA run |
⏱️ Performance Benchmark Report: 6be7f96Performance shiftsFull benchmark resultsGenerated by GHA run |
|
Thanks for sticking with it! |
trexfeathers
added a commit
to trexfeathers/iris
that referenced
this pull request
Mar 27, 2024
tkknight
added a commit
to tkknight/iris
that referenced
this pull request
Apr 3, 2024
* upstream/main: (163 commits) Restore latest Whats New files. Whats new updates for `v3.9.0rc0` (SciTools#5899) nep29: drop py39 and support py312 (SciTools#5894) Support NetCDF v3 files in chunking control code. (SciTools#5897) Avoid computing lazy scalar coordinates when printing a Cube (v2) (SciTools#5896) Force pytest colour output on GitHub Actions (SciTools#5895) Make typing 3.9 compatible. Improve typing readability. Updated environment lockfiles (SciTools#5892) [pre-commit.ci] pre-commit autoupdate What's New entry for SciTools#5740 . Iris to GeoVista conversion (SciTools#5740) Try Union for type hinting. Type hinting. Fix typo. Re-introduce backwards compatible warning. Updated documentation. Remove loose references to fill value warnings. Advertise structured_um_loading performance regression. [pre-commit.ci] pre-commit autoupdate ...
tkknight
added a commit
to tkknight/iris
that referenced
this pull request
Apr 10, 2024
…th_numpydoc * upstream/main: (39 commits) Bump scitools/workflows from 2024.03.3 to 2024.04.0 (SciTools#5907) [pre-commit.ci] pre-commit autoupdate (SciTools#5906) Updated environment lockfiles (SciTools#5904) Ignore flaticon.com in linkchecks. (SciTools#5905) Implement lazy area weights (SciTools#5658) Add option to specify chunks in `iris.util.broadcast_to_shape` (SciTools#5620) Unpin sphinx (SciTools#5901) DOC: clarify save_pairs_from_cube docstring (SciTools#5783) Restore latest Whats New files. Whats new updates for `v3.9.0rc0` (SciTools#5899) nep29: drop py39 and support py312 (SciTools#5894) Support NetCDF v3 files in chunking control code. (SciTools#5897) Avoid computing lazy scalar coordinates when printing a Cube (v2) (SciTools#5896) Force pytest colour output on GitHub Actions (SciTools#5895) Make typing 3.9 compatible. Improve typing readability. Updated environment lockfiles (SciTools#5892) [pre-commit.ci] pre-commit autoupdate What's New entry for SciTools#5740 . Iris to GeoVista conversion (SciTools#5740) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
From the issue #5517. This PR adds the ability to convert an Iris cube into a polydata mesh and then extract a region of that to be able to be plotted using geovista. This is a one way operation as it does not include the ability to go the other way from geovista to iris. There was plenty of discussion of the scope of this PR in the original issue.
Consult Iris pull request check list