Set benchmark runs to error if the subprocess errors #5434
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trexfeathers
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## FEATURE_benchmarks #5434 +/- ##
=====================================================
Coverage ? 89.35%
=====================================================
Files ? 89
Lines ? 22417
Branches ? 5382
=====================================================
Hits ? 20030
Misses ? 1639
Partials ? 748 ☔ View full report in Codecov by Sentry. |
trexfeathers
force-pushed
the
bm_pr6_check
branch
from
2967636 to
dff97e0
Compare
ESadek-MO
approved these changes
Aug 18, 2023
Contributor
ESadek-MO
left a comment
ESadek-MO
left a comment
There was a problem hiding this comment.
Happy with this once rebased and tests run, thanks @trexfeathers
ESadek-MO
pushed a commit
that referenced
this pull request
Aug 21, 2023
* Improve benchmark runner printing (#5429) * More sensible print and run functions. * Avoid permanent modifications in _subprocess_runner. * Post on demand benchmark results as comment (big refactor) (#5430) * On demand benchmarking. * Correct gh query. * Correct assignee spacing. * What's new entry. * Better comparison commits for PR benchmarking (#5431) * Don't check out head_ref - benchmark the GH simulated merge commit instead. * What's New entry. * Warn via issue if overnight benchmarks fail (#5432) * Include a warning step for overnight benchmarking. * Fix for failure warning script. * Better formatting of warning issue title. * What's new entry. * Minor benchmark improvements (#5433) * Use shlex.split() for bm_runner commands. * Minor documentation clarifications. * Set benchmark runs to error if the subprocess errors (#5434) * Set benchmark runs to error if the subprocess errors. * Still compare results even from a broken run. * Still upload reports if overnight run fails. * What's New entry. * Hard-code conda channel into asv_delegated_conda.py (#5435) * What's new entry. * What's New entry. * Hard-code conda channel into asv_delegated_conda.py . * Fix some rebase confusion in the What's New. * Inflate benchmark data to ensure laziness (#5436) * Inflate benchmark data to ensure laziness. * What's New entry. * Benchmark feature branch what's new entry (#5438) * What's new entry. * Correct user name @ESadek-MO. * Missing colon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Requires
Will need
git rebase upstream/FEATURE_benchmarksonce those are merged.Description
Fixes an oversight introduced when we switched away from Nox (#5215). Called process errors in
bm_runner.pyshould cause an error upstream. Without this: we have had some benchmarks erroring without us knowing about it.Also included handling to allow the overnight run to report whatever results it has, before erroring.
Demonstrations
I have temporarily created a different default branch on my fork:
trexfeathers:demo_20230817_main, which can simulate what would happen onmain.SciTools:main5899576542trexfeathers/iris#80a6deb765trexfeathers/iris#81Consult Iris pull request check list